Boost C++ Libraries: Ticket #859: boost::format ignores a user defined locale

owner, status changed; severity set

Samuel Krempp — Thu, 16 Aug 2007 19:39:53 GMT

owner changed from samuel_k to Samuel Krempp
status assigned → new
severity → Problem

component, description changed

René Rivera — Sat, 18 Aug 2007 14:34:35 GMT

component None → format
description modified (diff)

status, resolution changed

Samuel Krempp — Sun, 15 Nov 2009 10:19:15 GMT

status new → closed
resolution None → invalid

Do you have a sample program exhibiting an issue ?

The locale passed to boost::format constructor is not ignored, it is passed as "default" locale (i.e. last argument) to the put function by distribute : put<Ch, Tr, Alloc, T> (x, self.items_[i], self.items_[i].res_, self.buf_, boost::get_pointer(self.loc_) );

The put function itself relies on format_item's apply_on function to apply item's format state+locale (which will be self.loc_ unless an item's own locale was set in some way).

I will take a deeper look into format's locale handling - there is surely room for improvement here and there, and at least add a paragraph to the documentation with simple examples.

But user-defined locales are not "ignored", so closing the ticket as "invalid" unless sample complete program is supplied.

status changed; resolution deleted

anonymous — Tue, 15 May 2012 02:40:53 GMT

status closed → reopened
resolution invalid

problem here isn't that locale is ignored problem that method os.fill that tries to use facet before imbue to the stream see actor for the stream_format_state

if(width_ != -1)

os.width(width_);

if(precision_ != -1)

os.precision(precision_);

if(fill_ != 0)

os.fill(fill_);

os.flags(flags_); os.clear(rdstate_); os.exceptions(exceptions_);

#if !defined(BOOST_NO_STD_LOCALE)

if(loc_)

os.imbue(loc_.get());

else if(loc_default)

os.imbue(*loc_default);

#else

(void) loc_default; keep compiler quiet if we don't support locales

#endif

imbue should be at very beginning of the actor, not at the very end

dmarkman@… — Tue, 15 May 2012 02:43:37 GMT

we're getting segv for using boost::basic_format<char16_t> with appropriate locale with all appropriate facets because method os.fill uses std::ctype<char16_t> facet that wasn't ready

cc set

Wed, 01 Aug 2012 20:03:59 GMT

cc jonathan.jones@… added

Chris Newbold — Mon, 10 Sep 2012 16:47:28 GMT

We've applied the following patch locally, which appears to resolve the issues described above:

==== boost/boost/format/internals.hpp#4 (text) ====
***************
*** 105,110 ****
--- 105,118 ----
      void stream_format_state<Ch,Tr>:: apply_on (basic_ios & os,
                        boost::io::detail::locale_t * loc_default) const {
          // set the state of this stream according to our params
+ #if !defined(BOOST_NO_STD_LOCALE)
+         if(loc_)
+             os.imbue(loc_.get());
+         else if(loc_default)
+             os.imbue(*loc_default);
+ #else
+         (void) loc_default; // keep compiler quiet if we don't support locales
+ #endif
          if(width_ != -1)
              os.width(width_);
          if(precision_ != -1)
***************
*** 114,127 ****
          os.flags(flags_);
          os.clear(rdstate_);
          os.exceptions(exceptions_);
- #if !defined(BOOST_NO_STD_LOCALE)
-         if(loc_)
-             os.imbue(loc_.get());
-         else if(loc_default)
-             os.imbue(*loc_default);
- #else
-         (void) loc_default; // keep compiler quiet if we don't support locales
- #endif
      }
      template<class Ch, class Tr>
--- 122,127 ----

owner, status, version changed

James E. King, III — Wed, 11 Oct 2017 18:19:59 GMT

owner changed from Samuel Krempp to James E. King, III
status reopened → new
version None → Boost 1.34.0

status changed; resolution set

James E. King, III — Wed, 11 Oct 2017 18:22:44 GMT

status new → closed
resolution → fixed

This patch is present since 1.56.0.