Boost C++ Libraries: Ticket #8691: iostate is not checked after scan_keyword call
https://svn.boost.org/trac10/ticket/8691
<p>
Implementation of the duration_get::do_get_n_d_valid_unit and duration_get::do_get_valid_unit methods calls chrono_detail::scan_keyword and then unconditionally calls the facet.match_n_d_valid_unit and facet.match_valid_unit methods appropriately, no matter what is the value of the iostate flag.
IMO, the function should just return value "i" if iostate is not good after the scan_keyword call.
The proposed change is attached as a patch. The patch fixes also typos in doxygen comments of those functions.
</p>
en-usBoost C++ Libraries/htdocs/site/boost.png
https://svn.boost.org/trac10/ticket/8691
Trac 1.4.3tmmikolajczyk@…Thu, 13 Jun 2013 10:33:58 GMTattachment set
https://svn.boost.org/trac10/ticket/8691
https://svn.boost.org/trac10/ticket/8691
<ul>
<li><strong>attachment</strong>
→ <span class="trac-field-new">chrono_duration_get_bug_8691.patch</span>
</li>
</ul>
TicketviboesFri, 14 Jun 2013 05:16:43 GMTstatus, milestone changed
https://svn.boost.org/trac10/ticket/8691#comment:1
https://svn.boost.org/trac10/ticket/8691#comment:1
<ul>
<li><strong>status</strong>
<span class="trac-field-old">new</span> → <span class="trac-field-new">assigned</span>
</li>
<li><strong>milestone</strong>
<span class="trac-field-old">To Be Determined</span> → <span class="trac-field-new">Boost 1.54.0</span>
</li>
</ul>
<p>
Thanks for catching this. I'll try to fix it for 1.54.
</p>
TicketviboesFri, 14 Jun 2013 05:35:50 GMT
<link>https://svn.boost.org/trac10/ticket/8691#comment:2 </link>
<guid isPermaLink="false">https://svn.boost.org/trac10/ticket/8691#comment:2</guid>
<description>
<p>
Committed revision <a class="changeset" href="https://svn.boost.org/trac10/changeset/84768" title="Chrono: Apply patch for #8691.">[84768]</a>.
</p>
</description>
<category>Ticket</category>
</item>
<item>
<dc:creator>viboes</dc:creator>
<pubDate>Sat, 15 Jun 2013 10:36:42 GMT</pubDate>
<title>status changed; resolution set
https://svn.boost.org/trac10/ticket/8691#comment:3
https://svn.boost.org/trac10/ticket/8691#comment:3
<ul>
<li><strong>status</strong>
<span class="trac-field-old">assigned</span> → <span class="trac-field-new">closed</span>
</li>
<li><strong>resolution</strong>
→ <span class="trac-field-new">fixed</span>
</li>
</ul>
<p>
(In <a class="changeset" href="https://svn.boost.org/trac10/changeset/84793" title="Chrono: fix #8691,#8696 and update history.">[84793]</a>) Chrono: fix <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/8691" title="#8691: Bugs: iostate is not checked after scan_keyword call (closed: fixed)">#8691</a>,<a class="closed ticket" href="https://svn.boost.org/trac10/ticket/8696" title="#8696: Bugs: chrono compilation error on Solaris/gcc (closed: fixed)">#8696</a> and update history.
</p>
Ticket