Boost C++ Libraries: Ticket #8752: Bad check for invalid socket in boost::asio::detail::win_iocp_socket_service::accept()

type changed; cc set

Antony Polukhin — Wed, 21 Aug 2013 13:31:52 GMT

cc antoshkka@… added
type Bugs → Patches

To fix that error, just replace

    if (new_socket.get() >= 0)

with

    if (new_socket.get() == SOCKET_ERROR)

alb — Wed, 21 Aug 2013 16:41:13 GMT

Or better platform independent constant boost::asio::detail::socket_error_retval. But SOCKET_ERROR is OK too since win_iocp_socket_service.cpp is windows-only.

Kevin.Vlack@… — Fri, 23 Aug 2013 13:05:39 GMT

Replying to apolukhin:

To fix that error, just replace

    if (new_socket.get() >= 0)

with

    if (new_socket.get() == SOCKET_ERROR)

Since that line checks if the socket is valid*, I believe that should be:

if (new_socket.get() != SOCKET_ERROR)

status changed; resolution set

chris_kohlhoff — Tue, 01 Oct 2013 08:16:10 GMT

status new → closed
resolution → fixed

Fixed on trunk in [85745] and [85755]. Merged to release in [85838].