Boost C++ Libraries: Ticket #8764: Improve traits of Boost.Move

status changed; resolution set

Ion Gaztañaga — Thu, 01 Aug 2013 15:25:20 GMT

status new → closed
resolution → fixed

Fixed in revision 85182

Antony Polukhin — Fri, 16 Aug 2013 08:13:54 GMT

I'm afraid that the improved trait breaks one of the tests in libs/move/test/move.hpp.

Following assert:

   BOOST_STATIC_ASSERT((boost::has_nothrow_move<copyable>::value == false));

will be failing now. According to C++11 Standard is_nothrow_move_constructible evaluates to true if the following code does not throw:

copyable var(std::move(nonconst_copyable_variable))

Such code does not throw even if the copyable has no move constructor, but has a nothrow copy constructor.

Following solution could be used to fix tests:

   // Attempt to move construct `copyable` type won't throw exceptions in C++03 and C++11
   BOOST_STATIC_ASSERT((boost::has_nothrow_move<copyable>::value == true));

Ion Gaztañaga — Tue, 20 Aug 2013 18:08:00 GMT

I think that would fix the test only for compilers that can deduce it won't throw. I think we should delete that line as we don't know what the compiler will deduce.

Antony Polukhin — Wed, 21 Aug 2013 07:45:56 GMT

Replying to igaztanaga:

I think that would fix the test only for compilers that can deduce it won't throw. I think we should delete that line as we don't know what the compiler will deduce.

I agree. is_nothrow_move_assignable and is_nothrow_move_constructible traits are covered by tests in Boost.TypeTraits. Test in Boost.Move mainly duplicates those.