Boost C++ Libraries: Ticket #8768: win32 condition_variable::wait_until infinite wait in rare cases

attachment set

Wed, 03 Jul 2013 08:03:05 GMT

attachment → wait_until-example.cpp

repro example

owner, status changed

viboes — Wed, 03 Jul 2013 10:52:30 GMT

owner changed from Anthony Williams to viboes
status new → assigned

status changed; resolution set

viboes — Thu, 22 Aug 2013 22:18:09 GMT

status assigned → closed
resolution → wontfix

The example is to rare to take care of it.

szakharchenko@… — Sat, 24 Aug 2013 07:30:28 GMT

This isn't at all rare, for example, it's the final cause of my problems in #8323 (the current ticket's author just made it easier to reproduce, and his analysis is more correct than mine). That is, code hitting this problem from time to time can easily be written, and it is extremely hard to find the problem, unless you know that such waits can turn out to be infinite.

s.heil@… — Tue, 03 Sep 2013 11:56:19 GMT

We ran into this problem as well and after a lot of debugging, we found this ticket. In our case we got bit by that problem in production code, so we really hope it will get fixed. We also have a simple test, that in about 7 of 10 runs reproduces the problem:

#include <iostream>
#include <boost/thread.hpp>
#include <boost/chrono.hpp>
using namespace std;
int main( int argc, const char* argv[] )
{
	boost::mutex mutex;
	boost::condition_variable variable;
	boost::unique_lock<boost::mutex> lock( mutex );
	for ( int i = 5; i >= - 10; i -- ) {
		boost::chrono::time_point<boost::chrono::steady_clock> time =
			boost::chrono::steady_clock::now() + boost::chrono::milliseconds( i );
		std::cerr << "test " << i << ": " << " ... ";
		variable.wait_until( lock, time );
		std::cerr << "ok" << std::endl;
	}
}

The only solution we see right now is to not ever use wait_until, as it might block forever. So we are replacing all calls to wait_until in our code with calls to wait_for.

status changed; resolution deleted

viboes — Tue, 03 Sep 2013 21:01:19 GMT

status closed → reopened
resolution wontfix

Hi,

I think that #9079 includes two examples that are realistic and that seems to have the same issue.

I will try to fix it soon.

milestone changed

viboes — Sat, 07 Sep 2013 12:15:46 GMT

milestone To Be Determined → Boost 1.55.0

Please, could you try after updating with the following

Changeset [85591],[85592]

Thread: protect condition_variable/_any wait_for and wait_until from …

status changed; resolution set

viboes — Fri, 13 Sep 2013 19:04:57 GMT

status reopened → closed
resolution → fixed

Committed revision [85663].