Boost C++ Libraries: Ticket #9013: Create enum to make sign result more readable.

Boost C++ Libraries: Ticket #9013: Create enum to make sign result more readable. https://svn.boost.org/trac10/ticket/9013 The function 'sign' return 1, 0 or -1 depending on the signal of the z, but comparing the result with -1, 0 or 1 constants could make the source code bad readable specially for people that doesn't know what the 'sign' function return. <pre class="wiki">if (math::sign(value) == -1){ .... } </pre> I propose to create an enumerate type to test the result of the function with a constant, to create a more readable code. The compatibility with the previous implementation of the function is not broken. Suggested implementation of code: <pre class="wiki">enum Sign { SIGN_NEGATIVE = -1, SIGN_ZERO = 0, SIGN_POSITIVE = 1 } template <class T> inline Sign sign BOOST_NO_MACRO_EXPAND(const T& z) { return (z == 0) ? SIGN_ZERO : (boost::math::signbit)(z) ? SIGN_NEGATIVE : SIGN_POSITIVE; } </pre> The previous example comparison could be write as: <pre class="wiki">if (math::sign(value) == math::SIGN_NEGATIVE){ .... } </pre> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/9013 Trac 1.4.3