Boost C++ Libraries: Ticket #9029: Misprint in documentation

owner, status changed

viboes — Thu, 22 Aug 2013 16:58:42 GMT

owner changed from Anthony Williams to viboes
status new → assigned

milestone changed

viboes — Thu, 22 Aug 2013 22:12:11 GMT

milestone To Be Determined → Boost 1.55.0

Committed revision 85432.

ruslan_baratov@… — Fri, 23 Aug 2013 06:28:04 GMT

Thanks. Do you accept github pull requests?

viboes — Fri, 23 Aug 2013 06:56:41 GMT

Why not. The pb is to which github repository. Could you point me to which one?

ruslan_baratov@… — Fri, 23 Aug 2013 07:18:00 GMT

No, I'm just asking for future. Quote from here:

   Development should continue in Subversion only.

anonymous — Mon, 26 Aug 2013 16:55:50 GMT

I've send 'Fix documentation misprints' to github.

viboes — Mon, 26 Aug 2013 21:51:23 GMT

Replying to anonymous:

I've send 'Fix documentation misprints' to github.

Where can I see them?

ruslan_baratov@… — Tue, 27 Aug 2013 04:09:36 GMT

Replying to viboes:

Replying to anonymous:

I've send 'Fix documentation misprints' to github.

Where can I see them?

github.com/boostorg/thread/pull/1

viboes — Tue, 27 Aug 2013 11:33:34 GMT

Got it.

Committed revision [85485].

ruslan_baratov@… — Tue, 27 Aug 2013 13:05:34 GMT

I've send one more:

Fix with_lock_guard documentation

github.com/boostorg/thread/pull/3

BTW, can't find this function declaration, where is it?

viboes — Tue, 27 Aug 2013 22:32:52 GMT

Committed revision [85492].

The function is not provided. It is just an example.

ruslan_baratov@… — Wed, 28 Aug 2013 07:36:03 GMT

Replying to viboes:

Committed revision [85492].

Thank you.

The function is not provided. It is just an example.

Why not? Looks nice:

template <class Lockable, class Function, class... Args>
auto with_lock_guard(
    Lockable& m,
    BOOST_FWD_REF(Function) f,
    BOOST_FWD_REF(Args)... args
) -> decltype(f(args...)) {
  boost::lock_guard<Lockable> lock(m);
  return f(args...);
}

viboes — Wed, 28 Aug 2013 11:05:20 GMT

Replying to ruslan_baratov@…:

Replying to viboes:

Committed revision [85492].

Thank you.

The function is not provided. It is just an example.

Why not? Looks nice:
template <class Lockable, class Function, class... Args>
auto with_lock_guard(
    Lockable& m,
    BOOST_FWD_REF(Function) f,
    BOOST_FWD_REF(Args)... args
) -> decltype(f(args...)) {
  boost::lock_guard<Lockable> lock(m);
  return f(args...);
}

Well. All new function needs documentation, tests, fix bugs :( Please, create a new feature request (patches are as always welcome ;-)

ruslan_baratov@… — Wed, 28 Aug 2013 11:22:51 GMT

Replying to viboes:

Well. All new function needs documentation, tests, fix bugs :( Please, create a new feature request (patches are as always welcome ;-)

https://svn.boost.org/trac/boost/ticket/9058

status changed; resolution set

viboes — Sun, 08 Sep 2013 10:00:19 GMT

status assigned → closed
resolution → fixed

Committed revision [85603] on release branch.