Opened 16 years ago
Closed 12 years ago
#903 closed Patches (fixed)
[fix in git] inconsistent usage of function pointer typedefs
| Reported by: | Owned by: | Dave Abrahams | |
|---|---|---|---|
| Milestone: | Boost 1.36.0 | Component: | python USE GITHUB |
| Version: | Boost 1.34.0 | Severity: | Cosmetic |
| Keywords: | Cc: |
Description (last modified by )
The us of the function pointer typedef 'convertible_function' is inconsistent in boost/python/converter/registry.hpp and libs/python/converter/registry.cpp.
In registry.hpp 'insert' is defined as 'void insert(void* (*convert)(PyObject*), type_info)' whereas it's 'void insert(convertible_function, type_info)' in registry.cpp. The same applies to 'void insert(convertible_function, constructor_function, type_info)' and 'void push_back(convertible_function, constructor_function, type_info)'.
The attached patch replaces the function pointers with the appropriate typedefs.
Change History (5)
comment:1 by , 15 years ago
| Description: | modified (diff) |
|---|---|
| Owner: | changed from to |
| Severity: | → Showstopper |
| Status: | assigned → new |
comment:2 by , 15 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | → Boost 1.35.0 |
| Reporter: | changed from to |
| Severity: | Showstopper → Cosmetic |
| Status: | new → assigned |
| Version: | None → release 1.34.0 |
comment:3 by , 13 years ago
| Resolution: | None → fixed |
|---|---|
| Status: | assigned → closed |
| Summary: | inconsistent usage of function pointer typedefs → [fix in git] inconsistent usage of function pointer typedefs |
comment:4 by , 13 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
oops don't want to close these until the merge is done.
comment:5 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note:
See TracTickets
for help on using tickets.
Fixed in git:
http://gitorious.org/~straszheim/boost/straszheim/commit/7f951f166286140cefbb4f538ef1a0090a5d0e6a
will get merged to trunk at some point.