Opened 16 years ago

Last modified 12 years ago

#903 closed Patches (fixed)

inconsistent usage of function pointer typedefs — at Version 1

Reported by: sebastinas Owned by: Dave Abrahams
Milestone: Boost 1.36.0 Component: python USE GITHUB
Version: Boost 1.34.0 Severity: Cosmetic
Keywords: Cc:

Description (last modified by Dave Abrahams) 

The us of the function pointer typedef 'convertible_function' is inconsistent in boost/python/converter/registry.hpp and libs/python/converter/registry.cpp.

In registry.hpp 'insert' is defined as 'void insert(void* (*convert)(PyObject*), type_info)' whereas it's 'void insert(convertible_function, type_info)' in registry.cpp. The same applies to 'void insert(convertible_function, constructor_function, type_info)' and 'void push_back(convertible_function, constructor_function, type_info)'.

The attached patch replaces the function pointers with the appropriate typedefs.

Change History (1)

comment:1 by Dave Abrahams, 15 years ago

Description: modified (diff)
Owner: changed from david_abrahams to Dave Abrahams
Severity: → Showstopper
Status: assigned → new
Note: See TracTickets for help on using tickets.