Boost C++ Libraries: Ticket #9066: Add support for MultiPoint WKB format

attachment set

Mateusz Loskot — Thu, 29 Aug 2013 23:15:18 GMT

attachment → Mats-Taraldsvik-MultiPoint-WKB.patch

Combined patch with Mats' changes generated against SVN trunk r85516

Mateusz Loskot — Thu, 29 Aug 2013 23:27:30 GMT

The patch looks good to me. It's a good start for the WKB support for multi-geometries.

The read_wkb tests pass:

$ cd ~/dev/boost/_svn/trunk/libs/geometry/extensions/test/gis/io/wkb
$ b2
...patience...
...patience...
...found 1506 targets...
...updating 4 targets...
gcc.compile.c++ ../../../../../../../bin.v2/libs/geometry/extensions/test/gis/io/wkb/read_wkb.test/gcc-4.8.1/debug/read_wkb.o
In file included from ../../../../../../../boost/bind/bind.hpp:29:0,
                 from ../../../../../../../boost/bind.hpp:22,
                 from ../../../../../../../boost/test/impl/framework.ipp:46,
                 from ../../../../../../../boost/test/included/test_exec_monitor.hpp:22,
                 from read_wkb.cpp:14:
../../../../../../../boost/bind/arg.hpp: In constructor ‘boost::arg<I>::arg(const T&)’:
../../../../../../../boost/bind/arg.hpp:37:22: warning: typedef ‘T_must_be_placeholder’ locally defined but not used [-Wunused-local-typedefs]
         typedef char T_must_be_placeholder[ I == is_placeholder<T>::value? 1: -1 ];
                      ^
In file included from ../../../../../../../boost/tuple/tuple.hpp:33:0,
                 from ../../../../../../../boost/geometry/policies/relate/tupled.hpp:15,
                 from ../../../../../../../boost/geometry/strategies/intersection.hpp:17,
                 from ../../../../../../../boost/geometry/algorithms/detail/overlay/get_turns.hpp:43,
                 from ../../../../../../../boost/geometry/algorithms/disjoint.hpp:32,
                 from ../../../../../../../boost/geometry/algorithms/num_points.hpp:26,
                 from ../../../../../../../boost/geometry/algorithms/equals.hpp:36,
                 from read_wkb.cpp:19:
../../../../../../../boost/tuple/detail/tuple_basic.hpp: In function ‘typename boost::tuples::access_traits<typename boost::tuples::element<N, boost::tuples::cons<HT, TT> >::type>::const_type boost::tuples::get(const boost::tuples::cons<HT, TT>&)’:
../../../../../../../boost/tuple/detail/tuple_basic.hpp:228:45: warning: typedef ‘cons_element’ locally defined but not used [-Wunused-local-typedefs]
   typedef BOOST_DEDUCED_TYPENAME impl::type cons_element;
                                             ^
In file included from ../../../../../../../boost/geometry/extensions/gis/io/wkb/read_wkb.hpp:18:0,
                 from read_wkb.cpp:22:
../../../../../../../boost/geometry/extensions/gis/io/wkb/detail/parser.hpp: In static member function ‘static bool boost::geometry::detail::wkb::linestring_parser<L>::parse(Iterator&, Iterator, L&, boost::geometry::detail::wkb::byte_order_type::enum_t)’:
../../../../../../../boost/geometry/extensions/gis/io/wkb/detail/parser.hpp:239:46: warning: typedef ‘point_type’ locally defined but not used [-Wunused-local-typedefs]
         typedef typename point_type<L>::type point_type;
                                              ^
read_wkb.cpp: In function ‘int test_main(int, char**)’:
read_wkb.cpp:74:47: warning: typedef ‘linestring_type’ locally defined but not used [-Wunused-local-typedefs]
     typedef bg::model::linestring<point_type> linestring_type;
                                               ^
gcc.link ../../../../../../../bin.v2/libs/geometry/extensions/test/gis/io/wkb/read_wkb.test/gcc-4.8.1/debug/read_wkb
testing.capture-output ../../../../../../../bin.v2/libs/geometry/extensions/test/gis/io/wkb/read_wkb.test/gcc-4.8.1/debug/read_wkb.run
**passed** ../../../../../../../bin.v2/libs/geometry/extensions/test/gis/io/wkb/read_wkb.test/gcc-4.8.1/debug/read_wkb.test
...updated 4 targets...

attachment set

Mateusz Loskot — Wed, 23 Oct 2013 21:27:04 GMT

attachment → Mats-Taraldsvik-MultiPoint-WKB-linestring-test-fixed.patch

This is Mats' patch with missing #include <boost/geometry/strategies/strategies.hpp> added to fix compilation of linestring test case

attachment set

Mateusz Loskot — Thu, 24 Oct 2013 16:00:45 GMT

attachment → Mats-Taraldsvik-MultiPoint-WKB-linestring-test-fixed-polygon-added.patch

Previous version of the patch with polygon test added: compiles using GCC 4.8 and clang 3.3. svn diff against trunk r86415

attachment set

mats.taraldsvik@… — Sat, 16 Nov 2013 20:06:29 GMT

attachment → Mats-Taraldsvik-AddMultiWKBSupport.patch

Current complete patchset for multigeometry WKB support

attachment set

mats.taraldsvik@… — Sat, 16 Nov 2013 20:07:25 GMT

attachment → Mats-Taraldsvik-AddMultiLineStringMultiPolygonSupport.patch

Add support for MultiLinestring and MultiPolygon

mats.taraldsvik@… — Sat, 16 Nov 2013 20:09:12 GMT

I have implemented support and tests for MultiLinestring and MultiPolygon as well, and attached a patch for this, as well as a complete diff for the whole WKB support. I have used the git diff command described in the earlier comment to make it svn compatible.

attachment set

Mateusz Loskot — Tue, 26 Nov 2013 11:34:28 GMT

attachment → complete-extensions-gis-io-wkb-with-multi.patch

Updated last patch from Mats with WKB support for simple and multi-geometries. Added Jamfile.v2 files, fixed compiler warnings and added TODO comment.

Mateusz Loskot — Wed, 02 Mar 2016 20:32:39 GMT

This ticket can be considered addressed by this PR https://github.com/boostorg/geometry/pull/322