Boost C++ Libraries: Ticket #9216: format_date_parser::parse_date reads off end of format_str if it ends with a %

owner set

Marshall Clow — Wed, 09 Oct 2013 18:01:19 GMT

owner set to Marshall Clow

status, component changed

Marshall Clow — Wed, 09 Oct 2013 18:01:49 GMT

status new → assigned
component None → date_time

Marshall Clow — Wed, 09 Oct 2013 18:27:15 GMT

Roger -

Can you make the following change to your local install and re-run your test?

       while (itr != format_str.end() && (sitr != stream_end)) {
      if (*itr == '%') {
-       itr++;
+       if ( ++itr == format_str.end()) break;
        if (*itr != '%') { // <<< ERROR here

Thanks!

Thu, 10 Oct 2013 15:21:10 GMT

Thanks Marshall, I can confirm that making the code change fixes the specific problem. (I had hoped to have time to post a solution myself, but...)

However, I note that the same code pattern appears elsewhere in this header - in the

parse_month
parse_weekday
and parse_year

methods in this header file; and also in time_facet.hpp in two of the implementations of time_input_facet::get.

The same fix needs to be applied to these places too.

Marshall Clow — Thu, 10 Oct 2013 15:25:23 GMT

Thanks Roger.

I had found the other three places in this file, but hadn't looked in other files - will check.

Marshall Clow — Thu, 10 Oct 2013 15:43:32 GMT

(In [86230]) Fix several 'iterating past the end' bugs in Boost.DateTime; Refs #9216

Thu, 10 Oct 2013 15:50:49 GMT

Thanks :-)

status changed; resolution set

Marshall Clow — Tue, 15 Oct 2013 15:22:03 GMT

status assigned → closed
resolution → fixed

(In [86322]) Merge DateTime bug fix to Release; Fixes #9216