Boost C++ Libraries: Ticket #9266: Synchronized_value crashes MSVC12 (VS2013)

mjklaim@… — Fri, 18 Oct 2013 17:40:17 GMT

Removing the ifdefs in the synchronized_value related to BOOST_NO_CXX11_VARIADIC_TEMPLATES, and taking the code using variadic templates does fix the problem for me.

owner, status, description changed

viboes — Fri, 18 Oct 2013 18:00:43 GMT

owner changed from Anthony Williams to viboes
status new → assigned
description modified (diff)

viboes — Fri, 18 Oct 2013 18:04:53 GMT

Replying to mjklaim@…:

Removing the ifdefs in the synchronized_value related to BOOST_NO_CXX11_VARIADIC_TEMPLATES, and taking the code using variadic templates does fix the problem for me.

Please, could you provide a patch that resolve the issue, I don't understand which part must be removed in your case.

mjklaim@… — Fri, 18 Oct 2013 18:20:32 GMT

Sorry! I meant:

go into synchronized_value.hpp
search ifdefs testing BOOST_NO_CXX11_VARIADIC_TEMPLATES (there are 2 if I'm correct)
remove the ifdef and keep only the code that does use variadic templates.

Then boost::synchronized_value<int> does compile for me. I also forgot to say that I'm using the last boost thread interface (V4?).

I'm currently recompiling this revision of trunk boost with BOOST_NO_CXX11_VARIADIC_TEMPLATES defined only for MSVC <= VC11 , see if it impacts my current code (I suspect it will break my signals2 usage as said in the mailing list but I want to be sure).

component changed

viboes — Fri, 18 Oct 2013 20:16:11 GMT

component thread → config

Whether BOOST_NO_CXX11_VARIADIC_TEMPLATES must be defined or not is out of the scope of Boost.Thread and we need to fix it in Boost.Config.

Anyway it is a shame that Microsoft has not checked MSVC12 RC against the regression tests in boost before delivering.

mjklaim@… — Fri, 18 Oct 2013 20:28:59 GMT

Replying to viboes:

Anyway it is a shame that Microsoft has not checked MSVC12 RC against the regression tests in boost before delivering.

That being said, synchronized_value worked correctly with MSVC12 RC, at least in the revision I used in the past months (which I believe was r85663 ). Yesterday I was still using this revision with MSVC12 RC and had no other problem than this one: connect.microsoft.com/VisualStudio/feedback/details/802157/compiler-crash-mixing-boost-synchronized-value-and-boost-property-tree

I didn't check if something changed in config or synchronized_value since them so there are several potential source of problem here.

viboes — Fri, 18 Oct 2013 22:52:50 GMT

The last commit in synchronized_value was [85306].

John Maddock — Fri, 13 Dec 2013 13:02:41 GMT

There's a message thread on the lists to the effect that variadic templates are not fully supported yet: http://lists.boost.org/Archives/boost/2013/09/206389.php so I'm reluctant to re-enable them in Boost.Config. Sounds like this is a good case where a BOOST_WORKAROUND would be more appropriate in the thread lib?

BTW am I alone in finding it ironic that the way to work around a compiler bug is to enable an only-partially-working new feature? Oh well!

The change I'm suggesting for synchronized_value.hpp is to change:

#if ! defined BOOST_NO_CXX11_VARIADIC_TEMPLATES

#if ! defined(BOOST_NO_CXX11_VARIADIC_TEMPLATES) || BOOST_WORKAROUND(BOOST_MSVC, == 1800)

status changed; resolution set

John Maddock — Wed, 18 Jun 2014 18:02:37 GMT

status assigned → closed
resolution → worksforme

Update: this works for me with current develop and master branches and released VC12.