Boost C++ Libraries: Ticket #9271: C4512 warnings with VS 2013 RTM

Antony Polukhin — Sun, 20 Oct 2013 17:57:16 GMT

(In [86374]) Supressing MSVC2013 warnings and ensuring that lexical cast io classes are not copied (refs #9271)

Antony Polukhin — Sun, 20 Oct 2013 18:03:43 GMT

Thanks for reporting the issue! Could you please make some tests now? Are the warnings still there?

BTW, those classes do not exist in 1.55 (trunk has a big set of changes that were not merged to 1.55 release), so there is no need to worry about merging changes to 1.55

sebi707@… — Sun, 20 Oct 2013 19:19:55 GMT

Thanks! This removed those warnings but I'm still getting warnings in another file. I'm not sure if this belongs to the lexical_cast component but if I convert the compoments of a boost::smatch to int using lexical_cast I get these warnings:

boost/detail/basic_pointerbuf.hpp(54): warning C4505: 'boost::detail::basic_pointerbuf<CharT,BufferType>::setbuf' : unreferenced local function has been removed
boost/detail/basic_pointerbuf.hpp(55): warning C4505: 'boost::detail::basic_pointerbuf<CharT,BufferType>::seekpos' : unreferenced local function has been removed
boost/detail/basic_pointerbuf.hpp(56): warning C4505: 'boost::detail::basic_pointerbuf<CharT,BufferType>::seekoff' : unreferenced local function has been removed

I guess these warnings are not really VS 2013 specific as the previous reported warnings also occur with VS 2010 if you compile with warning level 4.

Antony Polukhin — Mon, 21 Oct 2013 06:46:02 GMT

(In [86377]) Suppress some of the Level 4 MSVC warnings in the basic_pointerbuf.hpp (refs #9271)

Antony Polukhin — Mon, 21 Oct 2013 06:50:57 GMT

Could you please make some tests now? Are the warnings still there? Maybe there are some warnings in other libraries? (Unfortunately I do not have access to the MSVC2013 compiler)

raad@… — Mon, 21 Oct 2013 08:29:55 GMT

In r86377, there is a #pragma warning(pop) without a matching #pragma warning(push) before the #pragma warning(disable: 4505). This leaves the warning disabled. Additionally, this leads to a new warning "C4193: #pragma warning(pop) : no matching '#pragma warning(push)'".

Antony Polukhin — Mon, 21 Oct 2013 09:21:37 GMT

(In [86378]) Add missing #pragma wraning(push) (refs #9271)

Antony Polukhin — Mon, 21 Oct 2013 09:25:09 GMT

Hope I forget nothing... Is it OK now?

raad@… — Mon, 21 Oct 2013 09:31:18 GMT

Works for me now, thank you!

Antony Polukhin — Mon, 21 Oct 2013 09:32:35 GMT

Thank you for reporting this bug!

status, milestone changed; resolution set

Antony Polukhin — Mon, 21 Oct 2013 09:32:55 GMT

status new → closed
resolution → fixed
milestone To Be Determined → Boost 1.56.0

status changed; resolution deleted

sebi707@… — Mon, 21 Oct 2013 12:05:33 GMT

status closed → reopened
resolution fixed

Unfortunatly this didn't fix the warning for me. It seems that you cannot disable it by just wrapping the class with #pragma warning. The warning has to be disabled for the whole compilation unit. Here you can find some more informations: http://stackoverflow.com/questions/3051992/compiler-warning-at-c-template-base-class

I'm not sure what would be the best way to get rid of the warning. Declaring the functions as inline seems to work but it's not really a nice solution.

Antony Polukhin — Tue, 22 Oct 2013 09:07:03 GMT

(In [86388]) Another attempt to suppress MSVC warnings (refs #9271)

Antony Polukhin — Tue, 22 Oct 2013 09:10:44 GMT

GCC and Clang give no warning about adding an inline hint for virtual functions. Did it help to suppress MSVC warning?

sebi707@… — Tue, 22 Oct 2013 09:58:11 GMT

Yes thanks! All the warnings are gone now.

status changed; resolution set

Antony Polukhin — Tue, 12 Nov 2013 17:15:13 GMT

status reopened → closed
resolution → fixed

(In [86654]) Merged a big bunch of internal code changes from trunk for lexical_cast: dropped support of antique compilers, code changed to produce a smaller binaries and simplify compiler's work, simplified and shortened the code, common with other libraries code moved to 'detail/basic_pointerbuf.hpp' (fixes #9046, fixes #9070, fixes #9271)