Boost C++ Libraries: Ticket #9284: WaitForSingleObject(mutex) must handle WAIT_ABANDONED

anonymous — Tue, 22 Oct 2013 07:40:43 GMT

huyuguang@… — Mon, 28 Oct 2013 02:00:21 GMT

I think maybe I am wrong. Here the code should not handle the wait_abondon and should throw a exception. The caller can catch the exception and check if it should handle the exception or just ignore it.

Ion Gaztañaga — Mon, 28 Oct 2013 16:30:05 GMT

Thanks for the report. I think it should treat wait_abandoned specially, because the mutex will be locked, so it should detect wait_abandoned and unlock the mutex before throwing the exception. Otherwise, the client might try to lock() again and it would deadlock.

anonymous — Tue, 29 Oct 2013 02:26:29 GMT

void lock() {

unsigned long ret = winapi::wait_for_single_object(m_mtx_hnd, winapi::infinite_time); if(ret != winapi::wait_object_0){

if(ret != winapi::wait_abandoned) {

error_info err = system_error_code(); throw interprocess_exception(err);

} else {

winapi::release_mutex(m_mtx_hnd); throw interprocess_exception(0, "wait_abandoned");

}

}

}

bool try_lock() {

unsigned long ret = winapi::wait_for_single_object(m_mtx_hnd, 0); if(ret == winapi::wait_object_0){

return true;

} else if(ret == winapi::wait_timeout){

return false;

} else if(ret == winapi::wait_abandoned){

winapi::release_mutex(m_mtx_hnd); throw interprocess_exception(0, "wait_abandoned");

} else{

error_info err = system_error_code(); throw interprocess_exception(err);

}

}

bool timed_lock(const boost::posix_time::ptime &abs_time) {

if(abs_time == boost::posix_time::pos_infin){

this->lock(); return true;

}

boost::posix_time::ptime now = microsec_clock::universal_time(); if(now >= abs_time){

return false;

}

unsigned long ret = winapi::wait_for_single_object

(m_mtx_hnd, (abs_time - now).total_milliseconds());

if(ret == winapi::wait_object_0){

return true;

} else if(ret == winapi::wait_timeout){

return false;

} else if(ret == winapi::wait_abandoned){

winapi::release_mutex(m_mtx_hnd); throw interprocess_exception(0, "wait_abandoned");

} else{

error_info err = system_error_code(); throw interprocess_exception(err);

}

}

status changed; resolution set

Ion Gaztañaga — Tue, 29 Oct 2013 08:05:29 GMT

status new → closed
resolution → fixed

(In [86512]) Fixes #9284 ("WaitForSingleObject(mutex) must handle WAIT_ABANDONED")

status, version changed; resolution deleted

megaposer — Thu, 30 Jul 2015 09:35:44 GMT

status closed → reopened
version Boost 1.54.0 → Boost 1.58.0
resolution fixed

The fix is incomplete and should have been applied to all wait_for_single_object API wrapper methods in boost_1_58_0/boost/interprocess/sync/windows/winapi_wrapper_common.hpp:

line 49 : inline bool winapi_wrapper_try_wait_for_single_object(void *handle) ...
line 64 : inline bool winapi_wrapper_timed_wait_for_single_object(void *handle, const boost::posix_time::ptime &abs_time) ...

In both cases, the state WAIT_ABANDONED => winapi::wait_abandoned can occur and is not properly handled.

That means the orphaned synchronization object will be acquired, but the code would throw an exception without previously releasing the synchronization object.

Next time another thread tries to acquire the synchronization object, the object would still be locked. If the same thread tries to acquire the object, it would succeed, but the number of releases would not correctly offset the number of acquisitions.

attachment set

Fri, 31 Jul 2015 12:30:03 GMT

attachment → boost_interprocess_1_58_0.patch

Patch to fix remaining synchronization object WAIT_ABANDONDED issues

Thu, 08 Mar 2018 15:13:50 GMT

Created pull request, that fixes this: https://github.com/boostorg/interprocess/pull/51