Boost C++ Libraries: Ticket #9295: PHOENIX_LIMIT macro clash: property_tree -- log/sink

owner, component changed; cc set

Andrey Semashev — Wed, 23 Oct 2013 15:27:14 GMT

cc Andrey.Semashev@… added
owner changed from Andrey Semashev to Thomas Heller
component log → phoenix

I think this needs to be resolved by Boost.Phoenix v2/v3 and Boost.Spirit maintainers. I don't see what can be done on Boost.Log part. My (naive) suggestion is to define PHOENIX_LIMIT in boost/phoenix/core/limits.hpp conditionally, or drop it altogether in favor of BOOST_PHOENIX_LIMIT.

Mon, 03 Feb 2014 19:56:30 GMT

I don't see why boost phoenix should define PHOENIX_LIMIT at all for its own use. I will test out offline not defining it and see what if anything breaks and fix it. It could break old code from Phoenix V2 however and so a conditional may be better with a note that is not encouraged.

Mon, 03 Feb 2014 19:57:43 GMT

Replying to John Fletcher <J.P.Fletcher@…>:

I don't see why boost phoenix should define PHOENIX_LIMIT at all for its own use. I will test out offline not defining it and see what if anything breaks and fix it. It could break old code from Phoenix V2 however and so a conditional may be better with a note that is not encouraged.

I meant that it is not encouraged.

Mon, 03 Feb 2014 20:04:21 GMT

A conditional will not work for the case where the other header comes second.

Mon, 03 Feb 2014 20:37:56 GMT

I have run the phoenix tests offlien without the definition of PHOENIX_LIMIT and nothing breaks.

Mon, 03 Feb 2014 20:56:49 GMT

boost/sprit has this:

boost/spirit/home/classic/attribute.hpp:29-31
#if !defined(PHOENIX_LIMIT)
#define PHOENIX_LIMIT 6
#endif // !defined(PHOENIX_LIMIT)

so I have put this conditional code into boost/phoenix :

boost/phoenix/core/limits.hpp:30-32
#if !defined(PHOENIX_LIMIT)
#define PHOENIX_LIMIT BOOST_PHOENIX_LIMIT
#endif

I will put that on test in develop.