Boost C++ Libraries: Ticket #9334: Boost 1.55.0 beta1: circular_buffer incompatible with shared memory allocators?

owner changed

Jan Gaspar — Mon, 04 Nov 2013 21:00:23 GMT

owner changed from Jan Gaspar to No-Maintainer

anonymous — Fri, 29 Nov 2013 18:22:54 GMT

I am afraid that this bug has now been hidden away from view because of the owner change, and no Cc: added.

This isssue is making it impossible for me to use the circular_buffer from 1.55.

Jan Gaspar — Fri, 29 Nov 2013 21:43:28 GMT

Sorry about this, but I'm not maintaining circular_buffer any more.

attachment set

saleyn@… — Sun, 01 Dec 2013 02:01:41 GMT

attachment → circular_buffer.patch

Patch that fixes reported issue with circular buffer

saleyn@… — Sun, 01 Dec 2013 02:04:11 GMT

Who is in charge of maintaining this project, can we get this fix applied to to the new release?

Jan Gaspar — Sun, 01 Dec 2013 08:51:32 GMT

Sure, you can fix the issue and also you can start maintaining the library if you wish.

Sun, 01 Dec 2013 15:20:26 GMT

Replying to jano_gaspar:

Sure, you can fix the issue and also you can start maintaining the library if you wish.

Do you mind pushing this fix into the release area? Aside from fixing this issue, unfortunately, I have no resources to be able to become the maintainer of this project.

Jan Gaspar — Sun, 01 Dec 2013 23:18:00 GMT

You need to ask someone at boost dev mailing list to push it for you I'm afraid.

owner changed

Antony Polukhin — Mon, 02 Dec 2013 08:14:16 GMT

owner changed from No-Maintainer to Antony Polukhin

Antony Polukhin — Tue, 03 Dec 2013 12:20:49 GMT

This issue is not as easy as it looks like:

Replacing placement new with allocator's construct() breaks move emulation under C++03, where construct accepts parameter by const reference, while Boost.Move requires nonconst reference.

Older versions of circular buffer did not work well in DEBUG mode: std::memset was attempting to convert typename Allocator::pointer to void*.

Attached a patch that fixes the issue. Will be applied as soon as the GIT migration will be finished.

attachment set

Antony Polukhin — Tue, 03 Dec 2013 12:21:37 GMT

attachment → 9334.patch

More advanced patch, based on the previous one.

status changed

Antony Polukhin — Tue, 03 Dec 2013 12:24:42 GMT

status new → assigned

Tue, 03 Dec 2013 13:43:40 GMT

Thanks for looking into it!

Replying to apolukhin:

This issue is not as easy as it looks like:

Replacing placement new with allocator's construct() breaks move emulation under C++03, where construct accepts parameter by const reference, while Boost.Move requires nonconst reference.
Older versions of circular buffer did not work well in DEBUG mode: std::memset was attempting to convert typename Allocator::pointer to void*.
Attached a patch that fixes the issue. Will be applied as soon as the GIT migration will be finished.

Antony Polukhin — Tue, 10 Dec 2013 12:23:05 GMT

In commit1 and commit2 to GIT's developer branch this issue was addressed.

status, milestone changed; resolution set

Antony Polukhin — Wed, 05 Feb 2014 11:50:45 GMT

status assigned → closed
resolution → fixed
milestone To Be Determined → Boost 1.56.0

Fix merged to master branch