Boost C++ Libraries: Ticket #9567: De-serialization of enable_shared_from_this through base class pointer fails

attachment set

t_regan@… — Mon, 13 Jan 2014 10:55:57 GMT

attachment → test_shared_from_this.cpp

Test demonstrating enable_shared_from_this deserialization problem

t_regan@… — Tue, 14 Jan 2014 12:18:38 GMT

Correction to original description: enable_shared_from_this::weak_this_::px is NOT reconstructed - It is zero.

t_regan@… — Tue, 14 Jan 2014 12:24:04 GMT

Workaround: weak_this_ can be reconstructed by calling _internal_accept_owner (which fortunately is public) on each deserialized instance of Derived.

attachment set

t_regan@… — Tue, 14 Jan 2014 12:30:36 GMT

attachment → test_shared_from_this.2.cpp

Added test case to demonstrate workaround

Robert Ramey — Tue, 04 Feb 2014 01:16:37 GMT

I compiled and ran your example on my machine and have reproduced the problem.

Looking at your example, it seems to me that the serialization function of Derived should be:

	template<class Archive>
	void serialize(Archive & ar, const unsigned int version)
	{
	       ar & BOOST_SERIALIZATION_BASE_OBJECT_NVP(Base);
               ar & boost::serialization::make_nvp(
                     enable_shared_from_this,
                     boost::serialization::base_object<boost::enable_shared_from_this<Derived> >(*this)
                )
		ar & BOOST_SERIALIZATION_NVP(m_derived);
         }

Of course this begs the question as to how serialization for boost::enable_shared_from_this<Derived> should be implemented. Of hand I don't remember what boost::enable_shared_from_this<Derived>does right now. ( could guess but I'm not going to waste your time). So my advice is to figure out how to implement serialization for boost::enable_shared_from_this<Derived> and re-submit.

maybe something like the following would work

	template<class Archive>
	void serialize(Archive & ar, const unsigned int version)
	{
              boost_shared_ptr<Derived> m_sp = shared_from_this;
	       ar & BOOST_SERIALIZATION_BASE_OBJECT_NVP(Base);
	       ar & BOOST_SERIALIZATION_NVP(m_sp);
	       ar & BOOST_SERIALIZATION_NVP(m_derived);
         }

attachment set

Robert Ramey — Thu, 27 Feb 2014 17:50:39 GMT

attachment → test_enable_shared_from_this.cpp

status changed; resolution set

Robert Ramey — Thu, 10 Jul 2014 13:53:20 GMT

status new → closed
resolution → wontfix