Changes between Initial Version and Version 1 of Ticket #9612, comment 9


Ignore:
Timestamp:
Feb 3, 2014, 4:37:04 PM (9 years ago)
Author:
Brandon Kohn

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9612, comment 9

    initial v1  
    11Strictly speaking, all serialization library needs to do to support this fix is to modify the way the singleton is exported. Currently the export specifier is on the static members of singleton. Moving the specifier to the class level allows users to do their own exports of the instantiations. The change works with all supported msvc compilers (i.e. since vc8) and on gcc 4.8.2. Perhaps it would be worthwhile to make the change on develop and see how the test runners perform? If anything I would say the mixing of extern/dllexport in the extern.hpp macros is the more risky proposition. However, it's easy enough for a user to implement those if needed.
     2
     3Why was the export implemented on the members instead of at the class level initially? Was there some compiler which did not handle this? I know clang doesn't now, but it's logged as a bug.