Boost C++ Libraries: Ticket #961: boost::basic_binary_oprimitive not instantiated correctly

milestone changed; severity set

Thomas Witt — Fri, 01 Jun 2007 16:55:32 GMT

severity → Showstopper
milestone Boost 1.34.1 → Boost 1.35.0

Changed milestone to 1.35.0 per request from Robert Ramey.

owner set

Dave Abrahams — Wed, 11 Jul 2007 01:08:03 GMT

owner set to Robert Ramey

theta682@… — Tue, 20 Nov 2007 18:01:52 GMT

Any news? Will it be fixed in 1.35.0?

status, severity changed

Robert Ramey — Fri, 30 Nov 2007 02:16:31 GMT

status new → assigned
severity Showstopper → Problem

Hmmm - these are implemented as primitives in basic_binary_?primitive.hpp (iff the compiler supports wide character strings). Derived classes forward to there so I can't see where there should be a problem.

theta682@… — Fri, 30 Nov 2007 08:33:07 GMT

There are template functions for wchar_t, but they are not instantiated implicitly. I have to apply this patch:

Index: C:/Projects/contrib/boost-1.34.1/libs/serialization/src/binary_iarchive.cpp =================================================================== --- C:/Projects/contrib/boost-1.34.1/libs/serialization/src/binary_iarchive.cpp (revision 33976) +++ C:/Projects/contrib/boost-1.34.1/libs/serialization/src/binary_iarchive.cpp (revision 33977) @@ -26,6 +26,11 @@

char, std::char_traits<char>

;

+#ifndef BOOST_NO_STD_WSTRING +template<class Archive, class Elem, class Tr> +BOOST_ARCHIVE_OR_WARCHIVE_DECL(void) +basic_binary_iprimitive<Archive, Elem, Tr>::load(std::wstring & ws); +#endif

template class basic_binary_iarchive<binary_iarchive> ; template class binary_iarchive_impl<

binary_iarchive,

Index: C:/Projects/contrib/boost-1.34.1/libs/serialization/src/binary_oarchive.cpp =================================================================== --- C:/Projects/contrib/boost-1.34.1/libs/serialization/src/binary_oarchive.cpp (revision 33976) +++ C:/Projects/contrib/boost-1.34.1/libs/serialization/src/binary_oarchive.cpp (revision 33977) @@ -26,6 +26,16 @@

char, std::char_traits<char>

;

+#ifndef BOOST_NO_CWCHAR +template<class Archive, class Elem, class Tr> +BOOST_ARCHIVE_OR_WARCHIVE_DECL(void) +basic_binary_oprimitive<Archive, Elem, Tr>::save(const wchar_t * ws); +#ifndef BOOST_NO_STD_WSTRING +template<class Archive, class Elem, class Tr> +BOOST_ARCHIVE_OR_WARCHIVE_DECL(void) +basic_binary_oprimitive<Archive, Elem, Tr>::save(const std::wstring &ws); +#endif +#endif

template class basic_binary_oarchive<binary_oarchive> ; template class binary_oarchive_impl<

binary_oarchive,

Robert Ramey — Fri, 30 Nov 2007 18:20:19 GMT

a) I check the code and don't see why this should be necessary b) The serialization tests serialize wstring. See libs/serialization/test/A.hpp c) send me a small test case which should link but doesn't

Robert Ramey

status changed; resolution set

Robert Ramey — Sun, 02 Dec 2007 06:17:02 GMT

status assigned → closed
resolution → worksforme