Boost C++ Libraries: Ticket #9632: public method start_thread in boost::thread class

owner, status changed

viboes — Sat, 08 Feb 2014 09:06:50 GMT

owner changed from Anthony Williams to viboes
status new → assigned

Yes this is an error, it must be private. I will fix it.

viboes — Sat, 08 Feb 2014 15:30:45 GMT

This patch should solve the issue.

git diff ../include/boost/thread/detail/thread.hpp
diff --git a/include/boost/thread/detail/thread.hpp b/include/boost/thread/detail/thread.hpp
index 2434723..5053b8d 100644
--- a/include/boost/thread/detail/thread.hpp
+++ b/include/boost/thread/detail/thread.hpp
@@ -172,7 +172,7 @@ namespace boost
     private:
         bool start_thread_noexcept();
         bool start_thread_noexcept(const attributes& attr);
-    public:
+    //public:
         void start_thread()
         {
           if (!start_thread_noexcept())

Please, could you confirm if you don't find any regression with it?

milestone changed

viboes — Sun, 09 Feb 2014 03:00:11 GMT

milestone To Be Determined → Boost 1.56.0

Committed in develop

https://github.com/boostorg/thread/commit/4a54ac033132791ee488b9ca1a323fee205a0026

dinazil@… — Sun, 09 Feb 2014 05:05:10 GMT

This works for me (if I change just the .hpp file), but I didn't try compiling all of boost with this change. thanks!

status changed; resolution set

viboes — Sat, 15 Feb 2014 16:22:57 GMT

status assigned → closed
resolution → fixed

https://github.com/boostorg/thread/commit/750c849b0f0dff79a289111955260a4147ac7f59