Boost C++ Libraries: Ticket #9772: [libs/context] make_i386_sysv_elf_gas.S:52: Error: invalid instruction suffix for `pop'

ad@… — Wed, 12 Mar 2014 20:26:05 GMT

I have the three windows hosted toolchains targeting win/linux/max ready on my googledrive let me know if you need any of them for testing purpose you are welcome

ad@… — Wed, 12 Mar 2014 22:30:45 GMT

also another inconsistency I note building a darwin target with clang-darwin-4.2.1 and this change:

cpp -x assembler-with-cpp "$(>)" | as --32 -am -o "$(<)"

"cpp" does not exists with clang and "as" doesn't know the switch -a

summary changed

Thu, 13 Mar 2014 12:21:36 GMT

summary [libs/context] make_i386_sysv_elf_gas.S:52: Error: invalid instruction suffix for `pop' → [FIXED] [libs/context] make_i386_sysv_elf_gas.S:52: Error: invalid instruction suffix for `pop'

You can close this ticket, it has been fixed in this report [1]

[1] https://svn.boost.org/trac/boost/ticket/9774#comment:2

olli — Thu, 13 Mar 2014 13:14:47 GMT

I've added --32, --64, --x32 to GNU as command line - could you verify that the code is still working, please?

Thu, 13 Mar 2014 13:34:47 GMT

Sure it works all the build I did in [1] are after this last commit

Revision: 2775fe1c5d38b49e9554ea485b8a6ada0dc6461a Author: olk <oliver.kowalke@…> Date: 13/03/2014 08:50:36 Message: Update Jamfile.v2

add word size specifier to GNU as command line (required for cross-compiling; ELF only)

use property <abi> in file selection

Modified: build/Jamfile.v2

status changed; resolution set

olli — Thu, 13 Mar 2014 14:11:28 GMT

status new → closed
resolution → fixed

OK, thx

Thu, 13 Mar 2014 14:41:52 GMT

A bit offtopic but olli I have a question

When you write "untested.cpp - code for this platform is untested - please remove this file from build/Jamfile.v2 and report the test-result on boost-track !"

What is the boost-track ? I can't seem to find a mailing list with this exact name

Reporting to you anyway this untested proc worked fine here with the combined build I have tested in link [1]

--- "a/X:\\libs\\boost-dev\\libs\\context\\build\\Jamfile.v2"
+++ "b/X:\\libs\\boost-dev\\libs\\context\\build\\Jamfile.v2"
@@ -400,7 +400,6 @@ alias asm_context_sources
 alias asm_context_sources
    : asm/make_i386_x86_64_sysv_macho_gas.S
      asm/jump_i386_x86_64_sysv_macho_gas.S
-     untested.cpp
    : <abi>sysv
      <address-model>32_64
      <architecture>x86

olli — Thu, 13 Mar 2014 15:00:32 GMT

Replying to class101 <ad@…>:

When you write "untested.cpp - code for this platform is untested - please remove this file from build/Jamfile.v2 and report the test-result on boost-track !" What is the boost-track ?

boost's bug tracking system at https://svn.boost.org/trac/boost

Reporting to you anyway this untested proc worked fine here with the combined build I have tested in link [1]

--- "a/X:\\libs\\boost-dev\\libs\\context\\build\\Jamfile.v2"
+++ "b/X:\\libs\\boost-dev\\libs\\context\\build\\Jamfile.v2"
@@ -400,7 +400,6 @@ alias asm_context_sources
 alias asm_context_sources
    : asm/make_i386_x86_64_sysv_macho_gas.S
      asm/jump_i386_x86_64_sysv_macho_gas.S
-     untested.cpp
    : <abi>sysv
      <address-model>32_64
      <architecture>x86

yes, I've to remove untested.cpp from those entries which are verified to work

status, summary changed; resolution deleted

Mon, 17 Mar 2014 15:48:16 GMT

status closed → reopened
resolution fixed
summary [FIXED] [libs/context] make_i386_sysv_elf_gas.S:52: Error: invalid instruction suffix for `pop' → [libs/context] make_i386_sysv_elf_gas.S:52: Error: invalid instruction suffix for `pop'

Reopening because I caught today the same error with Apple's gcc-5666.3 (4.2.1) It seems -m32 is not passed, because 64-bit generation works fine and I could work around the problem with address-model=64 and fixing -m32 in the flags but that's a bit ugly hehe

Issue:

    "g++" -x assembler-with-cpp -O3 -finline-functions -Wno-inline -Wall -gdwarf-2 -fexceptions -DBOOST_ALL_NO_LIB=1 -DBOOST_CONTEXT_SOURCE -DNDEBUG -I"." -c -o "bin.v2\libs\context\build\darwin-4.2.1\release
\abi-sysv\address-model-32\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi\asm\make_i386_sysv_macho_gas.o" "libs\context\src\asm\make_i386_sysv_macho_gas.S
"
libs\context\src\asm\make_i386_sysv_macho_gas.S:51:suffix or operands invalid for `pop'
...failed darwin.compile.asm bin.v2\libs\context\build\darwin-4.2.1\release\abi-sysv\address-model-32\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi\asm\m
ake_i386_sysv_macho_gas.o...
...failed updating 1 target...
...updated 82 targets...

Command used:

b2 -j1 -d2 -q toolset=darwin variant=release abi=sysv address-model=32 binary-format=mach-o link=static,shared pch=off strip=on target-os=darwin threading=multi threadapi=pthread cxxflags="-w -m32" linkflags="-w -m32 -lstdc++" --without-python --without-mpi

Configuration used:

import option ;
using gcc :
: "X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/g++.exe"
: <archiver>X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/ar.exe
  <ranlib>X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/ranlib.exe
  <rc>X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/as.exe
  <linker-type>darwin
;
option.set keep-going : false ;

olli — Mon, 17 Mar 2014 16:43:52 GMT

boost.context compiles only assembler code - if gcc is invoked with the wrong flags on your platform then create an bug-report for boost.build.

Mon, 17 Mar 2014 16:50:20 GMT

ok thank you I will do that sorry

Tue, 18 Mar 2014 11:56:16 GMT

You can close this ticket

It seems related to a wrong toolset because just after adding to the command line architecture=x86, boost attempted to use -arch that do not exist in gcc-5666.3

But unfortunately it does not compile too with toolset=gcc target-os=darwin, it always fall in the unsupported.cpp of context

https://svn.boost.org/trac/boost/ticket/9786#comment:1

Tue, 18 Mar 2014 15:20:41 GMT

Hey olli I have been able to compile with gcc-5666.3 both 32-bit and 64-bit libs with

toolset=gcc linker-type=darwin

and the patch below

Not sure why gcc is left out support here because I don't get troubles compiling clangs 32, 64 and combined with the patch below too

--- Jamfile.v2.a	2014-03-18 15:33:05.377689400 +0100
+++ Jamfile.v2.b	2014-03-18 15:44:18.098748400 +0100
@@ -312,17 +312,6 @@
      <address-model>32
      <architecture>x86
      <binary-format>mach-o
-     <toolset>darwin
-   ;
-
-alias asm_context_sources
-   : asm/make_i386_sysv_macho_gas.S
-     asm/jump_i386_sysv_macho_gas.S
-   : <abi>sysv
-     <address-model>32
-     <architecture>x86
-     <binary-format>mach-o
-     <toolset>clang
    ;
 alias asm_context_sources
@@ -362,17 +351,6 @@
      <address-model>64
      <architecture>x86
      <binary-format>mach-o
-     <toolset>darwin
-   ;
-
-alias asm_context_sources
-   : asm/make_x86_64_sysv_macho_gas.S
-     asm/jump_x86_64_sysv_macho_gas.S
-   : <abi>sysv
-     <address-model>64
-     <architecture>x86
-     <binary-format>mach-o
-     <toolset>clang
    ;
 alias asm_context_sources

anonymous — Tue, 18 Mar 2014 17:47:59 GMT

does the lib compile for clang and darwin with this modification too?

Tue, 18 Mar 2014 18:49:41 GMT

For clang yes I can confirm it works for

toolset=clang-darwin target-os=darwin address-model=64 architecture=x86 toolset=clang-darwin target-os=darwin address-model=32 architecture=x86 toolset=clang-darwin target-os=darwin address-model=32_64 architecture=x86

toolset=gcc target-os=darwin linker-type=darwin address-model=64 architecture=x86 (gcc-4.2.1) toolset=gcc target-os=darwin linker-type=darwin address-model=32 architecture=x86 (gcc-4.2.1)

toolset=gcc target-os=linux address-model=64 architecture=x86 (gcc-4.8.2) toolset=gcc target-os=linux address-model=32 architecture=x86 (gcc-4.8.2)

toolset=gcc target-os=windows address-model=64 architecture=x86 (gcc-4.8.2) toolset=gcc target-os=windows address-model=32 architecture=x86 (gcc-4.8.2)

I could not test your set toolset=darwin because this set assumes it's a gcc supporting the -arch flag but the gcc-4.2.1 I have is gcc-5666.3 and -arch is unrecognized on this one, this is why I have to use toolset=gcc + <linker-type>darwin to work around this problem

Tue, 18 Mar 2014 18:51:24 GMT

For clang yes I can confirm it works for

toolset=clang-darwin target-os=darwin address-model=64 architecture=x86
toolset=clang-darwin target-os=darwin address-model=32 architecture=x86
toolset=clang-darwin target-os=darwin address-model=32_64 architecture=x86
toolset=gcc target-os=darwin linker-type=darwin address-model=64 architecture=x86 (gcc-4.2.1)
toolset=gcc target-os=darwin linker-type=darwin address-model=32 architecture=x86 (gcc-4.2.1)
toolset=gcc target-os=linux address-model=64 architecture=x86 (gcc-4.8.2)
toolset=gcc target-os=linux address-model=32 architecture=x86 (gcc-4.8.2)
toolset=gcc target-os=windows address-model=64 architecture=x86 (gcc-4.8.2)
toolset=gcc target-os=windows address-model=32 architecture=x86 (gcc-4.8.2)

Tue, 18 Mar 2014 19:07:33 GMT

I'm trying deeper with an untested set

toolset=gcc target-os=darwin linker-type=darwin address-model=32_64 architecture=x86 (gcc-4.2.1)

but this one doesn't seem to work, the produced libs are not multiarch, been searching around it seems someone works around with lipo but not sure it is worth working on this, anyway just sharing my links if you are interested in looking to gcc-5666.3 (4.2.1) and combined support: http://www.implbits.com/About/Blog/tabid/78/post/building-with-gcc-4-6-on-osx/Default.aspx

I doubt I will be using multiarch libs here anyway, I prefer to stick with gcc for all the three targeted arch rather than switching to clang just for the purpose of using multiarch

Anyway let me know if you happen to need so test build here I have compilers ready here

Wed, 19 Mar 2014 03:47:30 GMT

little correction

I realized gcc-5666.3 supports -arch

http://opensource.apple.com/source/gcc/gcc-5666.3/driverdriver.c

Administrator@WIN81PRO /x/libs/
$ gcc -arch i386 -arch x86_64
x86_64-apple-darwin10-gcc.exe: no input files
Administrator@WIN81PRO /x/libs/
$ g++ -arch i386 -arch x86_64
x86_64-apple-darwin10-g++.exe: no input files

will investigate then why I'm getting the -arch is unrecognized with toolset=darwin tomorrow and let you know

Wed, 19 Mar 2014 11:14:02 GMT

toolset=darwin is not suitable to the gcc-5666.3 I have here

    "X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/ar.exe" -static -o "bin.v2/libs/context/build/darwin-4.2.1/release/abi-sysv/address-model-64/binary-format-mach-o/link-static/pch-off/strip-on/target-os-darwi
n/threadapi-pthread/threading-multi/libboost_context-xgcc42-mt-1_56.a"    "bin.v2/libs/context/build/darwin-4.2.1/release/abi-sysv/address-model-64/binary-format-mach-o/link-static/pch-off/strip-on/target-os-
darwin/threadapi-pthread/threading-multi/asm/make_x86_64_sysv_macho_gas.o" "bin.v2/libs/context/build/darwin-4.2.1/release/abi-sysv/address-model-64/binary-format-mach-o/link-static/pch-off/strip-on/target-os
-darwin/threadapi-pthread/threading-multi/asm/jump_x86_64_sysv_macho_gas.o"
only one of -a and -[bi] options allowed
usage:  ar -d [-TLsv] archive file ...
        ar -m [-TLsv] archive file ...
        ar -m [-abiTLsv] position archive file ...
        ar -p [-TLsv] archive [file ...]
        ar -q [-cTLsv] archive file ...
        ar -r [-cuTLsv] archive file ...
        ar -r [-abciuTLsv] position archive file ...
        ar -t [-TLsv] archive [file ...]
        ar -x [-ouTLsv] archive [file ...]
...failed darwin.archive bin.v2\libs\context\build\darwin-4.2.1\release\abi-sysv\address-model-64\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi\libboost_
context-xgcc42-mt-1_56.a...
...failed updating 1 target...
...updated 18 targets...

Well anyway as this is a very old version I'm fine using toolset=gcc + <linker-type>darwin, it works fine for 32-bit, 64-bit, what it misses maybe a a toolset like toolset=gcc5663 to not require the need of setting <linker-type>darwin in a jam file

I will let you know if I can get a 32_64 build under gcc5666 working

Wed, 19 Mar 2014 11:38:58 GMT

and gcc-5666.3 with -arch returns

    "X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/gcc.exe"  -ftemplate-depth-128 -O3 -finline-functions -Wno-inline -Wall -arch x86_64 -w -DBOOST_ALL_NO_LIB=1 -DBOOST_CONTEXT_SOURCE -DNDEBUG  -I"." -c -o "bin
.v2\libs\context\build\gcc-4.2.1\release\abi-sysv\address-model-32_64\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi\unsupported.o" "libs\context\src\unsu
pported.cpp"
cc1plus.exe: error: unrecognized command line option "-arch"
...failed gcc.compile.c++ bin.v2\libs\context\build\gcc-4.2.1\release\abi-sysv\address-model-32_64\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi\unsuppor
ted.o...
...skipped <pbin.v2\libs\context\build\gcc-4.2.1\release\abi-sysv\address-model-32_64\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi>libboost_context-gcc4
2-mt-1_56.a for lack of <pbin.v2\libs\context\build\gcc-4.2.1\release\abi-sysv\address-model-32_64\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi>unsuppor
ted.o...
...failed updating 1 target...
...skipped 1 target...
...updated 14 targets...

I think it is a specific issue to my gcc-5666.3 cross compiler because I have used Ray Donnely's crosstool-ng to build it and I see he made patches to the driverdriver.c file so maybe something went wrong with such patch.

Will look with him if we eventually can get this fixed

Wed, 19 Mar 2014 11:52:59 GMT

OK Finally

Disregard my error on gcc-5666.3 and 32_64, it is technically a known issue with the cross compiler, here is my may to Ray

Hi Ray,
While compiling boost I think I have found an issue in gcc-5666.3
It compiles fine the 32-bit or 64-bit libs separately
but when attempting to use Apple's argument to build a fat lib -arch
i386 -arch x86_64
I'm getting
    "X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/g++.exe"
-ftemplate-depth-128 -O3 -finline-functions -Wno-inline -Wall -arch
x86_64 -w -DBOOST_ALL_NO_LIB=1 -DBOOST_CONTEXT_SOURCE -DNDEBUG  -I"." -c
-o
"bin.v2\libs\context\build\gcc-4.2.1\release\abi-sysv\address-model-32_64\binary-format-mach-o\link-static\pch-off\strip-on\target-os-darwin\threadapi-pthread\threading-multi\unsupported.o"
"libs\context\src\unsupported.cpp"
cc1plus.exe: error: unrecognized command line option "-arch"
Is rejected by cc1plus.exe but when you try
"X:/libs/gcc-5666.3-x86_64-apple-darwin10/bin/g++.exe" -arch alone it
does not complain of an unknown parameter
As I see you have made patches on driverdriver.c with
5666.3/130-relocatable.patch maybe do you have an idea what could cause this

Ray

Yeah, this is a known issue, and you have got close to identifying the cause.
Basically we don't use driverdriver.c in ctng (my old toolchain4
project did use it though!)
If you look here:
  https://github.com/mingwandroid/toolchain4/blob/master/toolchain.sh#L1380
.. you can see how I compiled it in that project.
.. but really I want to (and started to) make the Autotools/Makefile
system in Apple's GCC build it automatically the way it should be
done.
.. but also, since GCC is fast becoming deprecated in the Apple world,
I wonder if I'll ever get round to that .. quite likely I wont.

So in short with a gcc-5666.3 crosscompiler, stick with toolset=gcc <linker-type>darwin and the patch in comment#13 and all is fine

status changed; resolution set

olli — Wed, 19 Mar 2014 16:11:02 GMT

status reopened → closed
resolution → fixed

commit pushed to branch develop - please verify (for merge with branch master required) and report, thx

PS: if possible please test it for universal build and combined architectures too

Wed, 19 Mar 2014 16:19:17 GMT

I dont get you with (for merge with branch master required)

I got this on the develop branch

git.exe submodule update --init
Submodule path 'libs/atomic': checked out 'c56a76c0841b52ae1b962d1e4fc3e723b5d574ce'
Submodule path 'libs/log': checked out '7513db8bfe2fe4b33ef2e9d73635fce38d7840e9'
Success (47344 ms @ 19/03/2014 17:18:26)

Wed, 19 Mar 2014 16:38:58 GMT

nvm I think I got it I do (correct me if I'm wrong Im not very familiar with git)

git checkout develop
git branch -vv
git pull
git submodule update --init

and then switching to master

git checkout master
git branch -vv
git pull
git submodule update --init

Wed, 19 Mar 2014 18:41:32 GMT

For me all is ok on develop - a28a807afe362440a75e18acbd716a9d0ac57323

cross-compiled all these builds without problems

toolset=clang-darwin target-os=darwin address-model=64 architecture=x86 (clang-3.4)
toolset=clang-darwin target-os=darwin address-model=32 architecture=x86 (clang-3.4)
toolset=clang-darwin target-os=darwin address-model=32_64 architecture=x86 (clang-3.4)
toolset=gcc target-os=darwin linker-type=darwin address-model=64 architecture=x86 (gcc-5666.3-4.2.1)
toolset=gcc target-os=darwin linker-type=darwin address-model=32 architecture=x86 (gcc-5666.3-4.2.1)
toolset=gcc target-os=linux address-model=64 architecture=x86 (gcc-4.8.2)
toolset=gcc target-os=linux address-model=32 architecture=x86 (gcc-4.8.2)
toolset=gcc target-os=windows address-model=64 architecture=x86 (gcc-4.8.2)
toolset=gcc target-os=windows address-model=32 architecture=x86 (gcc-4.8.2)

olli — Wed, 19 Mar 2014 20:09:27 GMT

OK, thx - will merge to branch master

Wed, 19 Mar 2014 20:38:31 GMT

what is the difference between master and develop ? Is the develop branch where all days commits are made and the master is a much stabler branch where you merge verified things from the develop branch right ?

anonymous — Sun, 01 Jun 2014 00:07:36 GMT

PPC/x86 - 32-64 was tested both with both clang-apple and gcc-apple

please refer to https://svn.boost.org/trac/boost/ticket/8266

Toolsets are different from the vanilla gcc.

marco.serantoni@… — Sun, 01 Jun 2014 00:26:30 GMT

10.9.1 - uses clang
10.6.8 - uses gcc

olli — Sun, 01 Jun 2014 08:24:09 GMT

Replying to anonymous:

PPC/x86 - 32-64 was tested both with both clang-apple and gcc-apple

please refer to https://svn.boost.org/trac/boost/ticket/8266
Toolsets are different from the vanilla gcc.

architectures universal (32_64) and combined enabled for PPC in branch develop and master