Boost C++ Libraries: Ticket #9801: I can no longer create and iterator_range from a stable_vector

Thu, 20 Mar 2014 22:11:08 GMT

Appears to have been caused by libs/range checkin 8b60f2c768521226bf9fe0bb6edcd0e2919f2702 iterator_range interop with variant.

status changed

Neil Groves — Wed, 07 May 2014 00:03:10 GMT

status new → assigned

I've compiled your example with both develop and master branches without error using GCC 4.8.2 on Ubuntu 14.04.

Can you please let me know if you can still reproduce the issue? If you can I'll configure a Windows machine and sort this out.

attachment set

Wed, 07 May 2014 16:11:04 GMT

attachment → ConsoleApplication6.7z

Wed, 07 May 2014 16:12:05 GMT

Yes, same problem. Visual Studio 2013 with Update 2 RC. I attached the project file if that helps. I will test on my mac and let if that is working.

Wed, 07 May 2014 16:12:52 GMT

I did git pull on all submodules before testing.

Wed, 07 May 2014 19:10:42 GMT

It compiles on CLANG just fine.

milestone changed

Neil Groves — Wed, 04 Jun 2014 12:23:27 GMT

milestone To Be Determined → Boost 1.56.0

I am really pleased that you have attached the project. I'll get my Windows box ready to compile this in a wee bit. I'll try to get this in with my other 1.56 changes.

owner, status, component changed

Neil Groves — Thu, 05 Jun 2014 13:07:06 GMT

owner changed from Neil Groves to Ion Gaztañaga
status assigned → new
component range → container

I have been able to reproduce the problem. This is a compiler defect that has plagued Microsoft C++ compilers for many major versions. It simply reaches a scalability point where the names become jumbled and muddled between namespaces. It is almost impossible to reproduce a small test case and therefore very difficult to get Microsoft to take the report seriously.

The reason that only stable_vector appears to be a problem is that it, quite legitimately uses the class name iterator within the boost::stable_vector_detail namespace. However the Microsoft compiler is confusing the class in boost::stable_vector_detail::iterator with the iterator typedef within stable_vector. I have proven this to be true by renaming boost::stable_vector_detail::iterator to boost::stable_vector_detail::sv_iterator and showing that this fixes the issue.

It is therefore clearly neither a defect in Boost.Container or Boost.Range, but try as I might there appears to only be the possibilty to work-around this problem by making a small change to Boost.Container.

I am therefore reassigning this defect to Boost.Container since I do not have write-access to fix this problem myself. It is clear that simply renaming iterator to sv_iterator fixes this issue.

attachment set

Thu, 05 Jun 2014 17:30:11 GMT

attachment → file.patch

patch file to work around the problem in the stable_vector_detail namespace

Thu, 05 Jun 2014 17:33:14 GMT

I can concur that the suggested work around works. I can also concur about visual c++, unfortunately I am locked in so if you could incorporate this work around so I don't have maintain my own version of stable_vector I would appreciate it.

status changed; resolution set

Ion Gaztañaga — Fri, 06 Jun 2014 11:29:29 GMT

status new → closed
resolution → fixed

Thanks for the patch. Modified and fixed also the test in:

[develop 790a879] Fixes Trac issue #9801 ("I can no longer create and iterator_range from a stable_vector")

3 files changed, 130 insertions(+), 137 deletions(-)