Boost C++ Libraries: Ticket #9880: [windows] boost::condition_variable.timed_wait() exception if system time < 1970

component changed; owner set

anonymous — Mon, 14 Apr 2014 11:24:12 GMT

owner set to az_sw_dude
component None → date_time

owner, status, component changed

viboes — Mon, 14 Apr 2014 17:11:43 GMT

owner changed from az_sw_dude to viboes
status new → assigned
component date_time → thread

description changed

viboes — Mon, 14 Apr 2014 17:13:07 GMT

description modified (diff)

viboes — Mon, 14 Apr 2014 17:17:17 GMT

This code has been there since the beginning.

Have you found a regression? If yes, on which version it was working?

Could you provide an example, please?

viboes — Mon, 14 Apr 2014 17:18:18 GMT

BTW, why do you want to set the current time < 1970?

alex — Tue, 15 Apr 2014 12:17:40 GMT

I am the developer of anti-virus, respectively, our product should work with any conditions that malicious software may do. We found that the boost has architectural problem with the fact that he is trying to get the system time in posix format when specifying relative time. We found some workarounds solutions, but a problem with the condition variable could not solve. Example executed on windows 8.1, visual studio 2012, boost_1_55_0. Thanks!

#include "targetver.h"
#include <stdio.h>
#include <tchar.h>
#include "windows.h"
#include "boost/thread.hpp"
#define IF_ERR_RET(x) if(!(x)) {printf("Error: %d in %s(%d)\n", GetLastError(), __FILE__, __LINE__); return FALSE;}
#define TRY try {
#define CATCH } catch(std::exception& exc) {printf("Exception %s in %s(%d)\n", exc.what(), __FILE__, __LINE__);}
bool setYear(int year)
{
	SYSTEMTIME tm;
	GetLocalTime(&tm);
	tm.wYear = year;
	IF_ERR_RET(SetLocalTime(&tm));
	return TRUE;
}
void Func(void)
{
	Sleep(10000);
}
int _tmain(int argc, _TCHAR* argv[])
{
	IF_ERR_RET(setYear(1950));
	TRY;
	boost::condition_variable cv;
	boost::mutex			mtx;
	boost::mutex::scoped_lock lck(mtx);
	cv.timed_wait(lck, boost::posix_time::milliseconds(1000)); // exception
	CATCH;
	TRY;
	boost::thread thr(&Func);
	thr.timed_join(boost::posix_time::milliseconds(1000)); // exception
	CATCH;
	TRY;
	boost::thread thr(&Func);
	thr.try_join_for(boost::chrono::milliseconds(1000)); // exception
	CATCH;
	TRY;
	boost::this_thread::sleep_for(boost::chrono::milliseconds(1000)); // exception
	CATCH;
	TRY;
	boost::posix_time::second_clock::local_time(); // exception
	CATCH;
	IF_ERR_RET(setYear(2014));
	return 0;
}

viboes — Tue, 15 Apr 2014 16:56:19 GMT

Ok, I understand your concern. I will take a look. Could you answer to the questions: Have you found a regression? If yes, on which version it was working?

alex — Wed, 16 Apr 2014 07:50:05 GMT

I was not looking for a regression, but I think that this error has always been. boost_1_51_0, boost_1_55_0 - the problem persists.

viboes — Sat, 19 Apr 2014 11:00:31 GMT

I have no access to a windows machine. So before updating the code I want to be sure it fixes the issue.

Please, could you point me where abs_time is used if relative is true?

Thanks in advance, Vicente

summary changed

viboes — Sat, 19 Apr 2014 11:10:18 GMT

summary boost::condition_variable.timed_wait() exception if system time < 1970 → [windows] boost::condition_variable.timed_wait() exception if system time < 1970

viboes — Sun, 14 Sep 2014 18:25:34 GMT

Could you tell me which exception is thrown?

viboes — Tue, 16 Sep 2014 06:26:42 GMT

I have removed the initialization

abs_time(boost::get_system_time())

status, milestone changed; resolution set

viboes — Tue, 23 Sep 2014 00:13:11 GMT

status assigned → closed
resolution → fixed
milestone To Be Determined → Boost 1.57.0