Boost C++ Libraries: Ticket #9886: patch to fix GCC -Wshadow warnings in multi_array https://svn.boost.org/trac10/ticket/9886 <p> upstreaming patch from <a class="missing wiki">LibreOffice</a> project, to fix compiler warnings </p> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/9886 Trac 1.4.3 mstahl@… Mon, 14 Apr 2014 13:14:17 GMT attachment set https://svn.boost.org/trac10/ticket/9886 https://svn.boost.org/trac10/ticket/9886 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">0002-multi_array-fix-GCC-Wshadow-warnings.patch</span> </li> </ul> Ticket Ronald Garcia Wed, 23 Apr 2014 17:45:58 GMT <link>https://svn.boost.org/trac10/ticket/9886#comment:1 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/9886#comment:1</guid> <description> <p> This is a big patch that renames a lot of variables and typedefs. Are particular instances of shadowing here problematic? Shadowing in general is useful for reusing sensible names, especially in a local context where there is no ambiguity. </p> </description> <category>Ticket</category> </item> <item> <author>mstahl@…</author> <pubDate>Mon, 28 Apr 2014 14:32:43 GMT</pubDate> <title/> <link>https://svn.boost.org/trac10/ticket/9886#comment:2 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/9886#comment:2</guid> <description> <p> we want to build <a class="missing wiki">LibreOffice</a> itself with -Wshadow (since that has found a couple of real bugs in our ancient code-base), and since boost's libraries have all the implementation in the headers that creates some problems for us. </p> <p> it would be perfectly fine for us if you suppress the warnings via "#pragma GCC diagnostic push" "#pragma GCC diagnostic ignored "-Wshadow"" in boost if you prefer that. </p> </description> <category>Ticket</category> </item> <item> <dc:creator>anonymous</dc:creator> <pubDate>Tue, 29 Apr 2014 23:25:39 GMT</pubDate> <title/> <link>https://svn.boost.org/trac10/ticket/9886#comment:3 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/9886#comment:3</guid> <description> <p> Sure. Could you propose a new patch against the current master repository? </p> </description> <category>Ticket</category> </item> <item> <author>mstahl@…</author> <pubDate>Wed, 30 Apr 2014 11:28:55 GMT</pubDate> <title>attachment set https://svn.boost.org/trac10/ticket/9886 https://svn.boost.org/trac10/ticket/9886 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">0001-multi_array-suppress-GCC-Wshadow-warnings-fixes-9886.patch</span> </li> </ul> Ticket mstahl@… Wed, 30 Apr 2014 11:30:08 GMT <link>https://svn.boost.org/trac10/ticket/9886#comment:4 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/9886#comment:4</guid> <description> <p> attached patch to suppress the warnings instead, in multi_array.hpp </p> </description> <category>Ticket</category> </item> <item> <dc:creator>Ronald Garcia</dc:creator> <pubDate>Thu, 01 May 2014 18:50:42 GMT</pubDate> <title>status, version changed; resolution set https://svn.boost.org/trac10/ticket/9886#comment:5 https://svn.boost.org/trac10/ticket/9886#comment:5 <ul> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">closed</span> </li> <li><strong>version</strong> <span class="trac-field-old">Boost Release Branch</span> → <span class="trac-field-new">Boost Development Trunk</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> Patch applied to develop branch. Thanks! </p> Ticket