Boost C++ Libraries: Ticket #9918: chrono compilation error on Solaris, funciton timegm

Thu, 17 Apr 2014 22:04:42 GMT

Rats. I see that the underbars in macro names screwed up the formatting of the text. I don't see a way to edit the original note. Here are the diffs again:

% diff time_point_io.hpp /tmp
39c39
<   || ( (defined(sun) || defined(__sun)) && defined __GNUC__) \
---
>   || (defined(sun) || defined(__sun)) \
44c44
<   || ( (defined(sun) || defined(__sun)) && defined __GNUC__) \
---
>   || (defined(sun) || defined(__sun)) \

description changed

viboes — Fri, 18 Apr 2014 16:34:52 GMT

description modified (diff)

status changed

viboes — Fri, 18 Apr 2014 16:36:29 GMT

status new → assigned

I suspect that the use of sun is because sun compilers defines either sun or sun.

Fri, 18 Apr 2014 16:49:05 GMT

All Sun compilers always define __sun when running on Solaris (SunOS). Old Sun compilers also defined sun, but that practice stopped some time ago. Maybe old versions of gcc or some other vendor's compilers didn't follow the practice of defining __sun. That I don't know. As I said before, unless someone knows of a specific reason for checking for sun, I suggest checking only for __sun.

milestone changed

viboes — Fri, 18 Apr 2014 18:44:25 GMT

milestone To Be Determined → Boost 1.56.0

This doesn't works this way. The way it works is"until we don't have a reason to change something we don't change it :)

https://github.com/boostorg/chrono/commit/9e3c81e439b3de5ca3e0d109f6245301119c84de

viboes — Sun, 27 Apr 2014 13:19:21 GMT

Please, let me know if the changes in develop fixes the issue.

status changed; resolution set

viboes — Sun, 27 Apr 2014 13:49:54 GMT

status assigned → closed
resolution → fixed

https://github.com/boostorg/chrono/commit/f66235d6b80838f7bf03118789af4b399cecd012