Boost C++ Libraries: Ticket #9944: Regression test relies on undefined compiler behavior

chris.cooper@… — Wed, 23 Apr 2014 21:02:30 GMT

std::numeric_limits<Number>::min() and std::numeric_limits<Number>::max() are not constant expressions unless c++11 is specified, so a better fix is

#if !defined(BOOST_NO_LIMITS) && !defined(BOOST_NO_CXX11_CONSTEXPR)
template <class Number> struct complement_traits {
   BOOST_STATIC_CONSTANT(Number, min = std::numeric_limits<Number>::min());
   BOOST_STATIC_CONSTANT(Number, max = std::numeric_limits<Number>::max());
};
#else
[SNIP] All of the other template definitions for complement_traits, complement_traits_aux, etc.
#endif

chris.cooper@… — Thu, 24 Apr 2014 15:06:48 GMT

Kim Barrett suggested using boost::integer_traits<Number>::const_min / const_max

It's not entirely clear what this file (numeric_traits_test.cpp) is testing - there is so much template stuff at the top, and then it looks like a lot of the tests are simply verifying that the templates work. There is data sent to std::cout which is perhaps helpful to developers, but not in an automated regression test. It appears the only thing that it tests (from an automated test point of view) is boost::detail::numeric_distance()?

owner, component changed

Thu, 26 Jun 2014 21:54:56 GMT

owner changed from René Rivera to No-Maintainer
component Regression Testing → utility