Changes between Version 8 and Version 9 of Guidelines/WarningsGuidelines

Timestamp:

Jan 8, 2011, 12:29:18 PM (12 years ago)

Author:

Paul A. Bristow

Comment:

Added warning as errors from Pete Bartlett

Guidelines/WarningsGuidelines

@@ -157 +157 @@
 }}}
 
-Using warning-as-errors will make it hard to miss warnings.
-  Microsoft command line option /WX,
+'''Defining warnings as errors'''
+
+  Using warning-as-errors will make it hard to miss or ignore warnings.
+  Microsoft command line option /WX, makes all warnings errors, but this may be too drastic a step.
+
+  The following have been recommended by Pete Bartlett to make the MSVC and GCC compilers behave as similarly as possible:
+
+  /we4288 - For-loop scoping (this is the default)
+
+  /we4238 - don't take address of temporaries
+
+  /we4239 - don't bind temporaries to non-const references (Stephan's "Evil Extension")
+
+  /we4346 - require "typename" where the standard requires it.
+
+and compile options:
+
+  /Zc:forScope - For loop scoping again (this is the default).
+
+  /DNOMINMAX - Don't define min/max macros (usually only applies if windows.h is involved).
+  (Note that suitable bracketing, for example, (std::numeric_limits<result_type>::max)(), will avoid clashes with min/max macros, and is required to avoid being named'n'shamed by the Boost inspection program. So it may be better to check that clashes are correctly avoided by bracketing because others may use when min/max macros are defined rather than using this compiler option.)
+
   gcc option -warning-as-errors
   gcc option -pedantic-errors
@@ -255 +275 @@
 ||C4996||'  this item is deprecated.||Many similar messages suggest using secure versions. Unless you strongly believe that the 'secure' versions are useful, suppress. [http://www.open-std.org/JTC1/sc22/wg14/www/docs/n1160.pdf WG14 Austin Group concerns] may guide. See also _CRT_SECURE_NO_DEPRECATE and other defines above.||#  pragma warning(disable: 4996) // '' was declared deprecated.||
 ||C6385||invalid data: accessing <buffer name>, the readable size is <size1> bytes, but <size2> bytes may be read.||Code analyser False warning C6385 when a function result is used as an array index. See [https://connect.microsoft.com/VisualStudio/feedback/details/281033/] suggests this can be suppressed, unless a check on array bounds is wanted/necessary.||
+
 
 '''GCC'''
@@ -634 +655 @@
 }}}
 
-    
-
-
-
-
-
- |? || class does not have a  virtual destructor||Suppress or provide a virtual destructor.||??||
+
+
+||?||class does not have a  virtual destructor||Suppress or provide a virtual destructor.||??||
 
 '''Intel'''