generate_uniform_real may go into infinite loop

[Markus Faerber <mf@…>]

See uniform_real_distribution.hpp:

template<class Engine, class T> T generate_uniform_real(

Engine& eng, T min_value, T max_value, boost::mpl::true_ / is_integral<Engine::result_type> */)

{

for(;;) {

typedef T result_type; typedef typename Engine::result_type base_result; result_type numerator = static_cast<T>(subtract<base_result>()(eng(), (eng.min)())); result_type divisor = static_cast<T>(subtract<base_result>()((eng.max)(), (eng.min)())) + 1; BOOST_ASSERT(divisor > 0); BOOST_ASSERT(numerator >= 0 && numerator <= divisor); T result = numerator / divisor * (max_value - min_value) + min_value; if(result < max_value) return result;

}

}

Please add a "BOOST_ASSERT(max_value > min_value);".

If one declares something like

boost::random::mt19937 mt; boost::random::uniform_real_distribution<double> dist(0.0, 0.0);

dist(mt) makes generate_uniform_real go into an infinite loop.

Thank you and best regards.

[harris.pc@…]

Hi,

I see you have added the asserts, but could you also please adjust the comments? see attached patch,

Thanks, Paul