boost/geometry/strategies/cartesian/distance_pythagoras.hpp does not include boost/numeric/cast/conversion.hpp

[smspillaz@…]

This results in a compiler error when the latter header is not included before the former about a missing boost::numeric_cast.

Boost version by apt-cache policy libbopst-dev

apt-cache policy libboost-dev libboost-dev:

Installed: 1.54.0.1ubuntu1 Candidate: 1.54.0.1ubuntu1 Version table:

* 1.54.0.1ubuntu1 0

500 ​http://au.archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status

[awulkiew]

This should be fixed now, this commit:

​https://github.com/boostorg/geometry/commit/48bb75137da9473f2707d31f4b7f7e2d02931aac

adds

#include <boost/geometry/util/math.hpp>

which includes <boost/numeric/conversion/cast.hpp>

Or should it be included explicitly in distance_pythagoras.hpp?

[smspillaz@…]

That depends - are end users permitted to use distance_pythagoras.hpp directly?

[awulkiew]

Yes, more enlightened user should be able to include e.g. only the algorithm and the strategy he needs.

To be perfectly clear. The commit mentioned above adds the required include indirectly: distance_pythagoras.hpp -> boost/geometry/util/math.hpp -> boost/numeric/conversion/cast.hpp