Opened 8 years ago

Closed 8 years ago

#10653 closed Bugs (wontfix)

doc: typos

Reported by: akim demaille <akim@…> Owned by: Antony Polukhin
Milestone: Boost 1.58.0 Component: variant
Version: Boost 1.56.0 Severity: Cosmetic
Keywords: Cc:

Description

This page:

http://www.boost.org/doc/libs/1_56_0/doc/html/BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS.html

is really fishy. Really, "VARAINT", not "VARIANT"? "VIZITOR", not "VISITOR"??? "BOOST", not "BOOOOST"?

That's indeed what the code reads:

#ifndef BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS
#   define BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS 4
#endif

but what's the point?

Also, the end of http://www.boost.org/doc/libs/1_56_0/doc/html/variant/tutorial.html#variant.tutorial.recursive about multi visitation is not clear to me. Typically, it seems that bool_like_t what meant to be used, but is not.

Change History (3)

comment:1 by Antony Polukhin, 8 years ago

Milestone: To Be DeterminedBoost 1.58.0
Owner: changed from ebf to Antony Polukhin
Status: newassigned

Unfortunately BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS can not be changed, because such change will break user's code.

Multi visitation section in Tutorial was right, but I've simplified it a little bit in develop branch.

comment:2 by akim demaille <akim@…>, 8 years ago

Hi.

Still, it should fairly easy to do something like this:

#ifndef BOOST_VARIANT_MAX_MULTIVISITOR_PARAMS
  // Bugward compatibility.
# ifndef BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS
#  define BOOST_VARIANT_MAX_MULTIVISITOR_PARAMS BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS
# else
#  define BOOST_VARIANT_MAX_MULTIVISITOR_PARAMS 4
# endif
#endif

// Bugward compatibility.
#undef  BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS
#define BOOST_VARAINT_MAX_MULTIVIZITOR_PARAMS BOOST_VARIANT_MAX_MULTIVISITOR_PARAMS

and drop dead typos.

comment:3 by Antony Polukhin, 8 years ago

Resolution: wontfix
Status: assignedclosed
Note: See TracTickets for help on using tickets.