boost::filesystem::path::parent_path() with redundant separator returns wrong value

[Kolya Kosenko <kolya.kosenko@…>]

boost::filesystem::path::parent_path() function with redundant separator at the end of directory don't return parent directory, it just removes this separator.

Ubuntu 12.04, gcc 4.6.3

Following test fails:

test/path_unit_test.cpp

@@ -662 +662 @@
     CHECK(path("/").parent_path().string() == "");
     CHECK(path("/foo").parent_path().string() == "/");
     CHECK(path("/foo/bar").parent_path().string() == "/foo");
+    CHECK(path("/foo/bar/").parent_path().string() == "/foo");
 
     CHECK(path("/foo/bar/baz.zoo").filename().string() == "baz.zoo");
 

[Renu Tyagi <renu.tyagi@…>]

Patch for bug.

[Renu Tyagi <renu.tyagi@…>]

As per my finding Boost considers parent path of /foo/ as /foo and not just /. This is shown in /libs/filesystem/path_test.cpp . But if still it is a bug, then here is the patch for bug and corresponding patch for path_test.cpp.

[Beman Dawes]

The behavior is correct, so there no bug in that sense.

There is a bug, however, in the sense that the reference documentation is unclear. To fix that, examples and notes have been added to the reference documentation to show why the returned value is in fact correct, and to provide rationale for that behavior. See [path.itr], and [path.decompose] parent_path() and filename() sections of the reference docs.

As a result of those doc changes, this issue is being marked as "fixed" rather than "invalid".

Thanks,

--Beman