remove_if is broken for slist

[Georgy]

the following smaple produce a compilation error in msvs 2013 upd 3

#include <boost/container/slist.hpp>

void foo()
{
    boost::container::slist<int> bar;
    bar.remove_if([](const int& p) { return p == 0; });
}

error C2247: 'boost::intrusive::detail::key_nodeptr_comp<Pred,boost::intrusive::bhtraits<T,boost::intrusive::slist_node_traits<void *>,normal_link,boost::intrusive::default_tag,2>>::operator ()' not accessible because 'boost::intrusive::detail::key_nodeptr_comp<Pred,boost::intrusive::bhtraits<T,boost::intrusive::slist_node_traits<void *>,normal_link,boost::intrusive::default_tag,2>>' uses 'private' to inherit from 'boost::intrusive::detail::ebo_functor_holder<KeyValueCompare>'

[Ion Gaztañaga]

The code works fine in Clang, I suspect it's a Visual C++ error with lambdas, as an equivalent:

struct functor
{
   bool operator()(const int& p) const{ return p == 0; }
};

   bar.remove_if(functor());

works fine.

[Georgy <gkorolev@…>]

Yes. Witch functor works fine! But, boost 1.56 in first case work correctly. I found the following example works.

void foo1()
{
    boost::container::slist<int> bar;
    int va = 0;
    bar.remove_if([&va](int p) { return p == va; });
}

It seems that something is wrong with empty closures.

[Ion Gaztañaga]

I've changed to public inheritance in classes deriving from ebo_function_holder as a workaround to this MSVC limitation:

[develop 12ee566] Workaround for bugs #10771 and #6720.