Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#11125 closed Bugs (wontfix)

Preprocessor definitions in wrap_python.hpp don't check for cygwin64

Reported by: chris.nixon@… Owned by: Ralf W. Grosse-Kunstleve
Milestone: To Be Determined Component: python USE GITHUB
Version: Boost 1.57.0 Severity: Problem
Keywords: Cc:

Description

Preprocessor definitions in /libs/python/include/boost/python/detail/wrap_python.hpp assume that cygwin is always 32bit (defining length of long as 4 and number of bits in a word as 32).

cygwin64 defines LP64, so it can be used to discriminate between cygwin32 and cygwin64.

Attached patch adds 64bit support.

Attachments (1)

0001-Add-cygwin64-support-to-wrap_python.hpp.patch (1.1 KB ) - added by chris.nixon@… 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by carlerik@…, 7 years ago

Fixing this would fix a lot of other bugs in dependant systems, like GH issue Valloric/YouCompleteMe#684

comment:2 by Ralf W. Grosse-Kunstleve, 7 years ago

Resolution: wontfix
Status: newclosed

Sorry, this components is no longer maintained. Could you please send your patch to github? https://github.com/boostorg/python

comment:3 by carlerik@…, 7 years ago

I can take Chris' changes and apply them to https://github.com/boostorg/python/blob/develop/include/boost/python/detail/wrap_python.hpp. I'll submit the patch tonight.

comment:4 by carlerik@…, 7 years ago

The patch has now been submitted as [pull request 49](https://github.com/boostorg/python/pull/49) on the Github tracker. I have kept Chris Nixon as the original author in the commit.

Note: See TracTickets for help on using tickets.