Opened 8 years ago
Closed 7 years ago
#11157 closed Bugs (fixed)
MSVC 8 warnings for BOOST_PP_IS_EMPTY in Boost.Phoenix because of Boost.Fusion
| Reported by: | Owned by: | Joel de Guzman | |
|---|---|---|---|
| Milestone: | Boost 1.61.0 | Component: | fusion |
| Version: | Boost 1.58.0 | Severity: | Cosmetic |
| Keywords: | fusion warnings msvc8 | Cc: | eldiener@…, andrey.semashev@… |
Description
Boost.Fusion in it's new facility to deduce memeber's types for BOOST_FUSION_ADAPT* macros mase use of BOOST_PP_IS_EMPTY, which should be kept for private use by Boost.Preprocessor and the newcoming VMD library.
This macro works really fine when used in conjunction to BOOST_PP_EMPTY. However it generates warnings in VS 2005 MSVC 8 compiler.
These warnings could be removed in that BOOST_PP_IS_EMPTY would be removed from the fusion codebase in favor to something like BOOST_MPL_PP_TOKEN_EQUAL.
Change History (6)
comment:1 by , 8 years ago
| Component: | None → fusion |
|---|---|
| Owner: | set to |
comment:2 by , 8 years ago
comment:3 by , 7 years ago
The fix is done, I'm currently setting up alot of MSVC versions aside to perform the testing, but on my github branch feature/ticket-11157-remove-BOOST_PP_IS_EMPTY it's all in and all test passes.
I'll make the pull-request as soon as I'm sure with older MSVCs.
comment:4 by , 7 years ago
Can I get minimal reproducible code? I'm trying to catch up Damien's patches.
comment:5 by , 7 years ago
| Milestone: | To Be Determined → Boost 1.61.0 |
|---|
Fixed: https://github.com/boostorg/fusion/pull/124
Joel, could you close this ticket?
comment:6 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I've made a fix for this in the branch feature/ticket-11157-remove-BOOST_PP_IS_EMPTY on my github fork (daminetreg).
I still need to adapt the documentation as I also added "auto" as keyword as sysnonym for BOOST_FUSION_ADAPT_AUTO as proposed by Andrey Semashev on the mailing list.