MSVS 2015 + boost::range: STL and Boost iterators

[Dennis Schneider <dsr@…>]

The attached test program compiled with MSVS 2013, but doesn't with MSVS2015 in debug mode and Boost-trunk as of 2015-08-05. The transform_iterator is recognised as Boost foward iterator, but only as STL input iterator because its reference type is int. Since boost::max_element uses std::max_element, it doesn't compile in debug mode with:

c:\program files (x86)\microsoft visual studio 14.0\vc\include\xutility(1005): error C2338: next requires forward iterator

I'd be happy if this code compiled and worked, or if otherwise the Boost assertion would fire because the transform iterator is not a Boost forward traversal iterator.

[Dennis Schneider <dsr@…>]

Code in question

[Dennis Schneider <dsr@…>]

Compiler output

[Michel Morin]

A possible fix would be to replace std::max_element with boost::first_max_element (in '<boost/algorithm/minmax_element.hpp>'). I'll make a PR on github soon.

The problems are still remaining for other algorithms that require more than InputIterator (of the standard iterator categories), though.

[anonymous]

Hello, is there some update on this issue? I'm using Boost 1.60.0 and my project doesn't build with VS2015 debug mode with the same error message. Is it fixed in more recent boost releases?

[Michel Morin]

​PR was merged to 'develop' branch, but not merged to 'master' branch. So it is not yet fixed in the released versions of Boost.

[anonymous]

Alternatively to using boost::first_max_element (it has some different signatures), one can substitute boost::range::min_element(x) with boost::range::min_element(x, std::greater<type_of_x>()). Useful if some input range has to be transformed. I didn't have such issues with min_element.