boost_1_59_0/boost/intrusive/sgtree.hpp:830: bad if test ?

[David Binderman <dcb314@…>]

[boost_1_59_0/boost/intrusive/sgtree.hpp:830]: (warning) Logical conjunction always evaluates to false: new_alpha < 0.5f && new_alpha >= 1.0f.

Source code is

if(new_alpha < 0.5f && new_alpha >= 1.0f) return;

Maybe better code

if(new_alpha < 0.5f

new_alpha >= 1.0f) return;

Compiling with gcc flag -Wlogical-op might help find further examples of this problem.

[Ion Gaztañaga]

Thanks for the report. It seems that -Wlogical-op is not part of -Wall due to some false positives. Fixed in:

​https://github.com/boostorg/intrusive/commit/259e4a939f3b69c79cd136d87f9f6479deb98104