Opened 7 years ago

Last modified 7 years ago

#12109 new Bugs

C4100 warning (unreferenced formal parameter) in json_parser

Reported by: gigaplex@… Owned by: Sebastian Redl
Milestone: To Be Determined Component: property_tree
Version: Boost 1.60.0 Severity: Regression
Keywords: C4100, json_parser Cc:

Description

I upgraded from boost 1.57.0 to 1.60.0, and now get build failures due to a C4100 warning while using VS2015 - unfortunately we're required to use the error on warning setting.

The transcode_codepoint function inside "property_tree\detail\json_parser\wide_encoding.hpp", amongst many other functions in the same file, have unreferenced parameters such as 'Sentinel end'.

Change History (1)

comment:1 by gigaplex@…, 7 years ago

When disabling error on warning to see if it will actually compile, I encountered another problem:

boost::property_tree::json_parser::detail::standard_callbacks<PTree>::new_tree': not all control paths return a value

The assert at the end of that function isn't sufficient. There's also an assert in one of the switch case statements in the same function, but there's no attempt made to stop release builds from falling through to the next case.

Note: See TracTickets for help on using tickets.