boost::posix_time::time_duration::sec_type is too small!

[anonymous]

This code:

sec_type total_seconds() const {

return static_cast<sec_type>(ticks() / ticks_per_second());

}

is unsafe as sec_type is int32_t while ticks() is int64_t.

See this post for an easy way to have inconsistent result when using boost::posix_time::time_duration::total_seconds().

sec_type should be enlarged to int64_t

[anonymous]

Forgot the link to "this post": ​http://stackoverflow.com/questions/37299652/whats-wrong-with-boostposix-timetime-durationtotal-seconds

[anonymous]

I met the same problem: ​http://stackoverflow.com/questions/40590921/boost-timed-wait-doesnt-wait-if-date-is-in-2116-year

[anonymous]

It looks like time_resolution_traits::v_type (boost/date_time/time_resolution_traits.hpp) should be changed to

typename v_type = boost::int64_t

for all the typedefs: day_type, hour_type, min_type, sec_type.

At the moment it uses int32_t.

[James E. King, III]

See #4543, fixed in 1.66.0

​https://github.com/boostorg/date_time/commit/818dea52f3f0c8b4f5172df13c5fa4f57340625f