Opened 6 years ago

Closed 6 years ago

#12642 closed Bugs (fixed)

Float parser slow without float.h

Reported by: mihai.babiac@… Owned by: Joel de Guzman
Milestone: To Be Determined Component: spirit
Version: Boost 1.61.0 Severity: Optimization
Keywords: float float.h cfloat Cc:

Description

The scaling function for the float/double parser has a fast specialization which is only enabled if the doubles respect standard IEEE-754. This is checked through the preprocessor macro DBL_MAX_10_EXP which is defined in float.h. I think this file should be included in the header or this should at least be mentioned in the docs.

https://github.com/boostorg/spirit/blob/develop/include/boost/spirit/home/support/detail/pow10.hpp#L47

Change History (3)

comment:1 by Joel de Guzman, 6 years ago

Can you please issue a pull request? Thanks!

in reply to:  1 comment:2 by anonymous, 6 years ago

Replying to djowel:

Can you please issue a pull request? Thanks!

I'm not certain where and how the header should be included, but I made a simple pull request.

https://github.com/boostorg/spirit/pull/226

comment:3 by Joel de Guzman, 6 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.