Opened 6 years ago

Closed 5 years ago

#12817 closed Bugs (fixed)

Too strong iterator requirements in qi::parse and qi::phrase_parse

Reported by: yegor.derevenets@… Owned by: Joel de Guzman
Milestone: To Be Determined Component: spirit
Version: Boost 1.63.0 Severity: Problem
Keywords: Cc:

Description

qi::parse and qi::phrase_parse currently check that the provided iterator type implements ForwardIterator concept. This seems to be a stronger check than necessary. In particular, ForwardIterator requires that *it returns a reference, which does not seem to be needed by the parsing functions.

I propose to replace the check with the check that the iterator type implements ReadableIterator and SinglePassIterator concepts.

Change History (3)

comment:1 by yegor.derevenets@…, 6 years ago

A possible fix: ​https://github.com/boostorg/spirit/pull/230

comment:2 by Nikita Kniazev <nok.raven@…>, 5 years ago

Fixed in ​https://github.com/boostorg/spirit/pull/320

comment:3 by Joel de Guzman, 5 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.