Opened 15 years ago

Closed 15 years ago

#1286 closed Bugs (fixed)

Missing/Incorrect dllimport/dllexport directives prevent Windows DLLs from building

Reported by: ddeakins@… Owned by: Robert Ramey
Milestone: To Be Determined Component: serialization
Version: Boost Development Trunk Severity: Regression
Keywords: Cc:

Description

Currently, there are a small collection of bugs in the trunk version of Boost.Serialization that prevent the libraries from compiling as a Windows DLL. Most of these problems relate to missing dllimport/dllexport directives or, in a couple places, to directives that shouldn't be there. Attached are patches to several files to correct these issues.

Attachments (3)

codecvt_null.cpp.patch (452 bytes ) - added by ddeakins@… 15 years ago.
Patch for lib\boost\serialization\src\codecvt_null.cpp
codecvt_null.hpp.patch (889 bytes ) - added by ddeakins@… 15 years ago.
Patch for boost\archive\codecvt_null.hpp
basic_oarchive.hpp.patch (862 bytes ) - added by ddeakins@… 15 years ago.
Patch for boost\archive\detail\basic_oarchive.hpp

Download all attachments as: .zip

Change History (5)

by ddeakins@…, 15 years ago

Attachment: codecvt_null.cpp.patch added

Patch for lib\boost\serialization\src\codecvt_null.cpp

by ddeakins@…, 15 years ago

Attachment: codecvt_null.hpp.patch added

Patch for boost\archive\codecvt_null.hpp

by ddeakins@…, 15 years ago

Attachment: basic_oarchive.hpp.patch added

Patch for boost\archive\detail\basic_oarchive.hpp

comment:1 by ddeakins@…, 15 years ago

The spam filter is blocking me from attaching the patches for interface_iarchive.hpp and interface_oarchive.hpp. Please see the relative post in the boost-devel mailing list for those patch files.

comment:2 by Robert Ramey, 15 years ago

Resolution: fixed
Status: newclosed

Hmmm - BOOST_ARCHIVE_DECL can't right. At the very least it should be BOOST_WARCHIVE_DECL

Also its not clear to me that this is necessary as I don't think this is called from outside the DLL.

For char archives this shouldn't be an issue at all as its inline code.

Anyway, it seems to be fixed in the trunk for now.

Robert Ramey

Note: See TracTickets for help on using tickets.