Opened 15 years ago

Closed 15 years ago

#1291 closed Bugs (fixed)

config.hpp fails to compile with gcc -Wundef

Reported by: andyc@… Owned by: Thorsten Ottosen
Milestone: Boost 1.35.0 Component: range
Version: Boost 1.34.1 Severity: Problem
Keywords: Cc: martind@… matthewh@…

Description

.../boost/range/config.hpp:41:5: "_MSC_VER" is not defined

There's been discussion about this line previously:

http://lists.boost.org/Archives/boost/2005/04/83935.php

I think this patch is the correct fix:

--- 1.1/boost/range/config.hpp 2007-08-17 03:59:06 -07:00
+++ edited//home/martind/work/3rdParty/boost_1_34_1/boost/range/config.hpp 2007-09-27 11:45:49 -07:00
@@ -37,8 +37,7 @@ BOOST_RANGE_DEDUCED_TYPENAME
 #error "macro already defined!"
 #endif
 
-//#if BOOST_WORKAROUND( BOOST_MSVC, < 1300 ) || __MWERKS__ <= 0x3003
-#if _MSC_VER <= 1300 && !defined( __COMO__ ) && !defined( __GNUC__ ) && __MWERKS__ <= 0x3003
+#if BOOST_WORKAROUND( BOOST_MSVC, < 1300 ) || BOOST_WORKAROUND( __MWERKS__, <= 0x3003 )
 #define BOOST_RANGE_NO_ARRAY_SUPPORT 1
 #endif

IE use BOOST_WORKAROUND.

Change History (2)

comment:1 by John Maddock, 15 years ago

Component: Nonerange
Milestone: To Be DeterminedBoost 1.35.0
Owner: set to Thorsten Ottosen

Looks to be a trivial patch, we should accept if at all possible.

comment:2 by Thorsten Ottosen, 15 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.