Opened 5 years ago
#13328 new Bugs
transitive_reduction.hpp in the Graph component contains two lines that use "not" instead of "!"
Reported by: | Owned by: | Jeremiah Willcock | |
---|---|---|---|
Milestone: | To Be Determined | Component: | graph |
Version: | Boost 1.65.0 | Severity: | Problem |
Keywords: | transitive reduction not negation | Cc: |
Description
Lines 108 and 110 of graph/transitive_reduction.hpp (current as of Boost 1.65.1) include expressions represent logical negation via the word "not" rather than the correct "!". As expected, this causes a compilation error. None of the other Graph template/header files have this issue, as far as I could tell, so I don't believe it's simply failing to include a header that sets "#define not !". Currently, in order to use transitive_reduction.hpp, one must define that macro in their source file before including the header, and that should not be necessary. The simple solution, of course, is to change "not" to "!" in those two locations. The altered lines read as follows:
108: if( ! edge_in_closure[i][j] ) {
110: if( ! edge_in_closure[i][k] ) {