Opened 4 years ago

Last modified 4 years ago

#13545 new Patches

Missing SAL-Präfixes for windows-function-imports.

Reported by: boost@… Owned by: Andrey Semashev
Milestone: To Be Determined Component: winapi
Version: Boost 1.67.0 Severity: Cosmetic
Keywords: SAL Präfixes. Cc:

Description

Moin Moin. Regarding "boost\winapi\dll.hpp" I wanted to mention, that MSVC and ICL are mourning. The solution seemed to be to add the SAL-Präfixes for windows-function-imports, that MS always adds to its SDK-Headers. Maybe it is possible to amend the file or to skip the declarations, if an according header can be included from the Windows-10-SDK. A am attaching my version.

Tschüß,

Michael.

P.S.: I would have been registering an account in order to verify myself, if I had seen an according link.

Attachments (2)

dll.hpp​ (8.1 KB ) - added by anonymous 4 years ago.
time.hpp​ (4.6 KB ) - added by boost@… 4 years ago.

Download all attachments as: .zip

Change History (5)

by anonymous, 4 years ago

Attachment: dll.hpp​ added

comment:1 by anonymous, 4 years ago

P².S.: In "boost\winapi\time.hpp" One even does need an additional <windows.h>-include at line 18.: # ifndef _WINDOWS_ # include<windows.h> # endif

by boost@…, 4 years ago

Attachment: time.hpp​ added

comment:2 by Andrey Semashev, 4 years ago

I don't quite understand what the problem is. If you have a compilation failure, please provide the error message and what compiler you are using.

The attached files use some markup that apparently relies on Windows SDK macros, which are not defined by Boost.WinAPI. As such, these files are not correct. An I really don't want to add an equivalent markup to Boost.WinAPI because it is extremely non-portable, even between different versions of MSVC.

comment:3 by Andrey Semashev, 4 years ago

Ping? Could you provide a better problem description?

Note: See TracTickets for help on using tickets.