Opened 15 years ago
Closed 14 years ago
#1432 closed Patches (fixed)
Missing includes and same compiler warnings
| Reported by: | Owned by: | Gennadiy Rozental | |
|---|---|---|---|
| Milestone: | Boost 1.36.0 | Component: | test |
| Version: | Boost Development Trunk | Severity: | Problem |
| Keywords: | Cc: |
Description
Hi,
the attached patch fixes some missing includes and corrects g++ 4.3 compiler warnings.
Jens
Attachments (1)
Change History (4)
by , 15 years ago
| Attachment: | boost.test.diff.gz added |
|---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
As you probably noticed some minor parts of the patch are wrong (I removed e.g namespace { check_is_close_t check_is_close; } as this isn't used in the header and I misinterpreted the unnamed namespace). Please note that I think I read that using variable definitions in unnamed namespaces is discouraged and the Boost specific vera test published some time ago on the boost list complained about this too.
Nevertheless every other part of the patch should be OK to commit, right?
comment:3 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Attaching the uncompressed patch failed again as it was considered as spam.
What a mess!