#1762 closed Bugs (fixed)
BOOST_DISABLE_THREADS should imply BOOST_SP_DISABLE_THREADS
| Reported by: | Owned by: | Peter Dimov | |
|---|---|---|---|
| Milestone: | Boost 1.36.0 | Component: | smart_ptr |
| Version: | Boost 1.35.0 | Severity: | Problem |
| Keywords: | Cc: |
Description
When I built my code with BOOST_DISABLE_THREADS defined, I was surprised to have to deal with threading issues in the shared_ptr library. Defining this variable should automatically define BOOST_SP_DISABLE_THREADS, or else the code in <detail/sp_counted_base.hpp> that says
#if defined( BOOST_SP_DISABLE_THREADS )
should really say
#if defined( BOOST_SP_DISABLE_THREADS ) || defined(BOOST_DISABLE_THREADS)
Change History (4)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
I think that either BOOST_DISABLE_THREADS and BOOST_SP_DISABLE_THREADS should have the same effect. The first applies globally across boost, the second only applies to smart pointers. I don't think it should be necessary for BOOST_SP_DISABLE_THREADS to be specified in addition to BOOST_DISABLE_THREADS.
Thanks for your boost efforts!
- Nigel
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
This should be fixed in [44369].
Note:
See TracTickets
for help on using tickets.
Unfortunately, Boost.Config defines BOOST_DISABLE_THREADS in some situations, so I can't rely on it to reflect the user's intent.