Opened 14 years ago

Closed 14 years ago

Last modified 10 years ago

#2170 closed Bugs (wontfix)

quotes in path string must be removed: build.bat

Reported by: Roderick Ford <develop@…> Owned by: René Rivera
Milestone: Boost.Jam 3.1.17 Component: bjam
Version: Boost.Jam 3.1.16 Severity: Problem
Keywords: Cc:

Description

in boost-jam-3.1.16: build.bat: line 287: set "PATH=%BOOST_JAM_TOOLSET_ROOT%bin;%PATH%"

need to strip " from path if possible...quotes in %PATH% resulted fatally without notification. else, add warning/fixme if test for quotes is positive.

Change History (4)

comment:1 by Vladimir Prus, 14 years ago

Owner: changed from Vladimir Prus to René Rivera

comment:2 by René Rivera, 14 years ago

Component: buildbjam
Milestone: Boost 1.36.0Boost.Jam 3.1.17
Status: newassigned
Version: Boost 1.35.0Boost.Jam 3.1.16

comment:3 by René Rivera, 14 years ago

Resolution: wontfix
Status: assignedclosed

It is extremely hard to remove quotes on any variables in Windows in a portable manner. To the point that it's not worth supporting for what is techincally an illegal use case. The PATH var, or any var for that matter, on Windows should ever be set to have quotes in it. If there is a program that is adding quotes in there it is that programs bug not bjam's bug.

comment:4 by rafael.anschau@…, 10 years ago

I downloaded boost and when I runed bootstrap.bat, it endeded without either stating success or failure, complaining it didn´t understand something on my path. I debugged boostrap.bat and found the problem was when calling build.bat with:

call .\build.bat %* > ..\..\..\..\bootstrap.log

The string had double quotes(sorry I no longer have the message) , and hypothesized that it didn´t understand double quotes. So I removed the quotes and it built fine.

build.bat should at least say something like "Sorry, bad PATH variable, couldn´t understand ...") to save the installer´s debugging time. Otherwise people will loose lots of time debugging the same problem.(Expecting other app developer not to add quotes is not realistic). Another solution is to write on the install documentation of boost: "Make sure that, before you run bootstrap.bat, your path doesn´t have double quotes. If it does, remove them."

Note: See TracTickets for help on using tickets.