install rules broken

[Maik Beckmann <Beckmann.Maik <at> googlemail <dot> com>]

tools/build/CMake/BoostCore.cmake contains

...
      # Install this module's headers
      install(DIRECTORY include/boost 
        DESTINATION ${BOOST_HEADER_DIR}
        COMPONENT ${libname}_headers
        PATTERN "CVS" EXCLUDE
        PATTERN ".svn" EXCLUDE)
...

This leads to something like

CMake Error at libs/fusion/cmake_install.cmake:36 (FILE):
  file INSTALL cannot find file
  "/home/maik/workspace/boost-cmake/libs/fusion/include/boost" to install

since the libs/$COMPONENT/include dirs have been removed from svn.

[Maik Beckmann <Beckmann.Maik <at> googlemail <dot> com>]

I guess what we want is

      # Install this module's headers
      install(DIRECTORY ${Boost_SOURCE_DIR}/boost/${libname}
        DESTINATION ${BOOST_HEADER_DIR}
        COMPONENT ${libname}_headers
        PATTERN "CVS" EXCLUDE
        PATTERN ".svn" EXCLUDE)

Note that ${Boost_SOURCE_DIR} isn't quoted, since cmake generated path variables (i.e. CMAKE_SOURCE_DIR) are escaped proper.

Patch is attached.

[Maik Beckmann <Beckmann.Maik <at> googlemail <dot> com>]

ping

[Douglas Gregor]

I don't think this is the right patch. The header-installation logic here is meant to apply to a "modularized" Boost, where the headers do reside in include/boost. It's true that this will fail with a non-modularized Boost, but this isn't the fix for that: in that case, we shouldn't create ANY install rule for the library, because the install(DIRECTORY) rule for the Boost headers in the top-level CMakeLists.txt will handle it.

[Maik Beckmann <Beckmann.Maik <at> googlemail <dot> com>]

OK.

So.. why have the include/boost folders been removed from the svn-repo? Just to make clear that this work has do be done?

[Douglas Gregor]

If you run "make modularize", CMake will move headers into the appropriate places for a modularized Boost.

[Maik Beckmann <Beckmann.Maik <at> googlemail <dot> com>]

Thank you. So what we really want is to make sure target modularize being done before make install.

[troy d. straszheim]

modularization temporarily disabled