Missing slash when iterating windows root path

[Lin Yi-Li <record.nctu.cis91@…>]

A windows root path without backslash or slash, ex. "C:", will cause the result of directory_iterator missing a slash after ':'. For example, it will produce a broken path such as "C:filename".

Here is a sample to produce this:

#include <iostream>
#include <locale>
#include <boost/filesystem.hpp>

using namespace boost::filesystem;

int main() {
	const char *drive_to_search = "C:";
	std::cout.imbue( std::locale());

	for( directory_iterator i( path( drive_to_search, native)), end; i != end; ++i) {
		std::cout << i->path() << std::endl;
	}

	return 0;
}

By tracing the stack, I think the problem is function boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits>::m_append_separator_if_needed() won't append a slash in case of merging windows root path and filename.

Here is the call stack starting at the constructor of directory_iterator.

boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits>::m_append_separator_if_needed()
boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits>::operator/=(const wchar_t *)
boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits>::operator/=(const boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits> & rhs)
boost::filesystem::operator/<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits>(const boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits> & lhs, const std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > & rhs)
boost::filesystem::basic_directory_iterator<boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits> >::m_init(const boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits> & dir_path)
boost::filesystem::basic_directory_iterator<boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits> >::basic_directory_iterator<boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits> >(const boost::filesystem::basic_path<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,boost::filesystem::wpath_traits> & dir_path)

[Beman Dawes]

"C:filename" is perfectly valid. Windows interprets the directory as being the current working directory on the C drive. This is demonstrated from the command line by:

dir

Volume in drive C has no label. Volume Serial Number is D4A2-EC0D

Directory of C:\boost\trunk\libs\filesystem\test\msvc\ticket_2260_test

01/11/2009 07:05 PM <DIR> . 01/11/2009 07:05 PM <DIR> .. 01/11/2009 07:12 PM <DIR> Debug 01/11/2009 07:05 PM 4,070 ticket_2260_test.vcproj 01/11/2009 07:15 PM 1,409 ticket_2260_test.vcproj.BGD.Administrator.user

2 File(s) 5,479 bytes 3 Dir(s) 210,340,593,664 bytes free

dir c:

Volume in drive C has no label. Volume Serial Number is D4A2-EC0D

Directory of C:\boost\trunk\libs\filesystem\test\msvc\ticket_2260_test

01/11/2009 07:05 PM <DIR> . 01/11/2009 07:05 PM <DIR> .. 01/11/2009 07:12 PM <DIR> Debug 01/11/2009 07:05 PM 4,070 ticket_2260_test.vcproj 01/11/2009 07:15 PM 1,409 ticket_2260_test.vcproj.BGD.Administrator.user

2 File(s) 5,479 bytes 3 Dir(s) 210,340,626,432 bytes free

Note the way that "dir c:" works.

If you want C:\ rather than the current C: directory, change line 10 to:

const char *drive_to_search = "C:
";

--Beman