Opened 14 years ago
Closed 13 years ago
#2435 closed Bugs (fixed)
execution_monitor.ipp not portable on slightly older FreeBSD machines
Reported by: | Owned by: | Gennadiy Rozental | |
---|---|---|---|
Milestone: | Boost 1.37.0 | Component: | test |
Version: | Boost Development Trunk | Severity: | Problem |
Keywords: | Cc: |
Description
boost/test/impl/execution_monitor.ipp
In the main switch statements, execution_monitor.ipp is now check for the optional specific signal codes which not all FreeBSD machines support (namely anything less than 7.0 does not set these codes in the kernel nor defines them in /usr/include/sys/signal.h).
The attached patch builds on 6,7 and CURRENT and should be innocuous to other platforms.
Attachments (1)
Change History (5)
by , 14 years ago
Attachment: | execution_monitor.ipp.patch added |
---|
comment:1 by , 14 years ago
Component: | Building Boost → test |
---|---|
Owner: | set to |
comment:2 by , 14 years ago
comment:3 by , 14 years ago
It is not and I am synced with trunk. The other thing is that the patch has a bug in it as attached (I don't know how this happened) but as per #1838 I want to check against anything less than FreeBSD 7.1 release which should be:
#ifdef FreeBSD_version < 701000
Source: http://www.freebsd.org/doc/en/books/porters-handbook/freebsd-versions.html
Other than that, I believe my patch is correct. One thing is I made it per signal test configurable for maximum flexibility at the cost of #ifdef ugliness. The other patch just skipped the tests altogether. I leave it up to test to do the right thing here. I believe my patch as it stands does not effect other platforms but a code review would be nice (since I myself found one bug!).
comment:4 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Patch against current trunk to fix this issue on FreeBSD